Enhance deleteById to be consistent with findById

seratch · Nov 9, 2023 · 78244ef · 78244ef
1 parent b76ba39
commit 78244ef
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/data_mapper.ts b/data_mapper.ts
@@ -197,15 +197,24 @@ export class DataMapper<Def extends Definition> {
     });
   }
 
-  async deleteById(args: DataMapperIdQueryArgs): Promise<DeleteResponse> {
-    const datastore = args.datastore ?? this.#defaultDatastore;
+  async deleteById(
+    args: DataMapperIdQueryArgs | string,
+  ): Promise<DeleteResponse> {
+    let datastore = this.#defaultDatastore;
+    let id = undefined;
+    if (typeof args === "string") {
+      id = args;
+    } else {
+      id = args.id;
+      datastore = args.datastore ?? this.#defaultDatastore;
+    }
     if (!datastore) {
       throw new ConfigurationError(this.#datastoreMissingError);
     }
     return await func.deleteById({
       client: this.#client,
       datastore,
-      id: args.id,
+      id,
       logger: this.#logger,
     });
   }

diff --git a/data_mapper_test.ts b/data_mapper_test.ts
@@ -69,6 +69,13 @@ mf.mock("POST@/api/apps.datastore.get", () => {
   );
 });
 
+mf.mock("POST@/api/apps.datastore.delete", () => {
+  return new Response(
+    JSON.stringify({ "ok": true }),
+    { status: 200 },
+  );
+});
+
 export const Surveys = DefineDatastore(
   {
     name: "surveys",
@@ -146,6 +153,9 @@ Deno.test("Run a query", async () => {
     attributes: { "#title": "title" },
     values: { ":title": "Off-site event ideas" },
   });
+
+  await dataMapper.deleteById("123");
+  await dataMapper.deleteById({ id: "123" });
 });
 
 Deno.test("Run a query with simple expressions", async () => {