Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repro case for scoped findAndCountAll failure #253

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Repro case for scoped findAndCountAll failure #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 33 additions & 14 deletions src/sscce-sequelize-6.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,21 +21,40 @@ export async function run() {
},
});

class Foo extends Model {}
class FooModel extends Model {}

Foo.init({
name: DataTypes.TEXT,
}, {
sequelize,
modelName: 'Foo',
});
FooModel.init(
{
id: {type: DataTypes.STRING, primaryKey: true}
},
{sequelize, modelName: 'FooModel'}
);

await FooModel.sync();

// You can use sinon and chai assertions directly in your SSCCE.
const spy = sinon.spy();
sequelize.afterBulkSync(() => spy());
await sequelize.sync({ force: true });
expect(spy).to.have.been.called;
class OtherModel extends Model {}

OtherModel.init(
{
id: {type: DataTypes.STRING, primaryKey: true},
modelId: {type: DataTypes.STRING, field: 'model_id'},
modelType: {type: DataTypes.ENUM('foo', 'bar'), field: 'model_type'}
},
{sequelize, modelName: 'OtherModel'}
);

console.log(await Foo.create({ name: 'TS foo' }));
expect(await Foo.count()).to.equal(1);
await OtherModel.sync();

FooModel.hasMany(OtherModel, {
foreignKey: 'modelId',
scope: {
modelType: 'foo'
}
});

await FooModel.findAndCountAll({
include: {
model: OtherModel
}
});
}
47 changes: 33 additions & 14 deletions src/sscce-sequelize-7.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,21 +21,40 @@ export async function run() {
},
});

class Foo extends Model {}
class FooModel extends Model {}

Foo.init({
name: DataTypes.TEXT,
}, {
sequelize,
modelName: 'Foo',
});
FooModel.init(
{
id: {type: DataTypes.STRING, primaryKey: true}
},
{sequelize, modelName: 'FooModel'}
);

await FooModel.sync();

// You can use sinon and chai assertions directly in your SSCCE.
const spy = sinon.spy();
sequelize.afterBulkSync(() => spy());
await sequelize.sync({ force: true });
expect(spy).to.have.been.called;
class OtherModel extends Model {}

OtherModel.init(
{
id: {type: DataTypes.STRING, primaryKey: true},
modelId: {type: DataTypes.STRING, field: 'model_id'},
modelType: {type: DataTypes.ENUM('foo', 'bar'), field: 'model_type'}
},
{sequelize, modelName: 'OtherModel'}
);

console.log(await Foo.create({ name: 'TS foo' }));
expect(await Foo.count()).to.equal(1);
await OtherModel.sync();

FooModel.hasMany(OtherModel, {
foreignKey: 'modelId',
scope: {
modelType: 'foo'
}
});

await FooModel.findAndCountAll({
include: {
model: OtherModel
}
});
}