Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds feature to exclude files from source #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nickschuch
Copy link

Adds support to exclude paths using globbing.

What would be the next steps for merging? Where would you like me to contribute tests?

Copy link
Member

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickschuch Thank you for your PR!

I think it's better to make the exclude rule definition more generic by specifying filter func (path string) bool instead of a pattern string, so that users can use not only glob but regexp, complete match and any other custom filter.

What would be the next steps for merging? Where would you like me to contribute tests?

Yes! Please add some tests to ensure it works as expected and won't be broken in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants