Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install gh by apk #86

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Install gh by apk #86

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab8dae5
Install gh by apk
at-wat Jul 16, 2024
ffb7891
Fix alpine package name
at-wat Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,6 @@

ARG ALPINE_VERSION=3.17

# ========================================
FROM alpine:${ALPINE_VERSION} as gh-downloader

RUN wget https://github.com/cli/cli/releases/download/v2.29.0/gh_2.29.0_linux_amd64.tar.gz -O - \
| tar xzfv - \
&& mv gh_* gh

# ========================================
FROM alpine:${ALPINE_VERSION}
ARG ALPINE_VERSION=3.17
Expand All @@ -30,6 +23,7 @@ RUN apk add --no-cache \
curl \
findutils \
git \
github-cli \
py3-pip \
py3-rosdep \
py3-rosinstall-generator \
Expand All @@ -42,10 +36,6 @@ RUN rosdep init \
&& sed -i -e 's|ros/rosdistro/master|alpine-ros/rosdistro/alpine-custom-apk|' \
/etc/ros/rosdep/sources.list.d/20-default.list

# TODO: use `apk add --no-cache gh` after dropping Melodic
COPY --from=gh-downloader /gh/bin/gh /usr/local/bin/
RUN gh --version

ENV HOME="/root"

ARG ROS_DISTRO="noetic"
Expand Down