Support SSL and AUTH for redis

[munishchouhan]

This PR will add:

1. enable ssl for redis rediss:// protocol
2. and password if auth is enabled

[pditommaso]

Instead of re-inviting the wheel, look at DefaultJedisClientConfig

  protected JedisFactory(final URI uri, final int connectionTimeout, final int soTimeout,
      final int infiniteSoTimeout, final String clientName, final SSLSocketFactory sslSocketFactory,
      final SSLParameters sslParameters, final HostnameVerifier hostnameVerifier) {
    if (!JedisURIHelper.isValid(uri)) {
      throw new InvalidURIException(String.format(
          "Cannot open Redis connection due invalid URI. %s", uri.toString()));
    }
    this.clientConfig = DefaultJedisClientConfig.builder().connectionTimeoutMillis(connectionTimeout)
        .socketTimeoutMillis(soTimeout).blockingSocketTimeoutMillis(infiniteSoTimeout)
        .user(JedisURIHelper.getUser(uri)).password(JedisURIHelper.getPassword(uri))
        .database(JedisURIHelper.getDBIndex(uri)).clientName(clientName)
        .protocol(JedisURIHelper.getRedisProtocol(uri))
        .ssl(JedisURIHelper.isRedisSSLScheme(uri)).sslSocketFactory(sslSocketFactory)
        .sslParameters(sslParameters).hostnameVerifier(hostnameVerifier).build();
    this.jedisSocketFactory = new DefaultJedisSocketFactory(new HostAndPort(uri.getHost(), uri.getPort()), this.clientConfig);
  }

[pditommaso]

Is it safe if the password is null?

[munishchouhan]

I am making changes to use JedisURIHelper

[pditommaso]

Not sure it's needed because I think that tries to lookup for the password in the Redis URI, instead we need to specify independently

[munishchouhan]

I have added password in config and if its null then check in URI

[munishchouhan]

password will be null if auth is not set, like currently we don't have that

should we make it compulsory?

[munishchouhan]

Tested locally with ssl and auth and its working successfully
Testing now in dev

[munishchouhan]

so after digging i found that, jedispool is working with ssl and auth, error is coming from SpillwayRateLimiter
I am looking into it

redis.clients.jedis.exceptions.JedisDataException: EXECABORT Transaction discarded because of: NOAUTH Authentication required.
	at redis.clients.jedis.Protocol.processError(Protocol.java:105)
	at redis.clients.jedis.Protocol.process(Protocol.java:162)
	at redis.clients.jedis.Protocol.read(Protocol.java:221)
	at redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:351)
	at redis.clients.jedis.Connection.getObjectMultiBulkReply(Connection.java:322)
	at redis.clients.jedis.TransactionBase.exec(TransactionBase.java:168)
	at redis.clients.jedis.Transaction.exec(Transaction.java:80)
	at com.coveo.spillway.storage.RedisStorage.addAndGet(RedisStorage.java:112)
	at com.coveo.spillway.Spillway.getExceededLimits(Spillway.java:215)
	at com.coveo.spillway.Spillway.tryCall(Spillway.java:154)
	at com.coveo.spillway.Spillway.tryCall(Spillway.java:142)
	at io.seqera.wave.ratelimit.impl.SpillwayRateLimiter.acquirePull(SpillwayRateLimiter.groovy:84)

[munishchouhan]

so after digging i found that, jedispool is working with ssl and auth, error is coming from SpillwayRateLimiter I am looking into it

redis.clients.jedis.exceptions.JedisDataException: EXECABORT Transaction discarded because of: NOAUTH Authentication required.
	at redis.clients.jedis.Protocol.processError(Protocol.java:105)
	at redis.clients.jedis.Protocol.process(Protocol.java:162)
	at redis.clients.jedis.Protocol.read(Protocol.java:221)
	at redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:351)
	at redis.clients.jedis.Connection.getObjectMultiBulkReply(Connection.java:322)
	at redis.clients.jedis.TransactionBase.exec(TransactionBase.java:168)
	at redis.clients.jedis.Transaction.exec(Transaction.java:80)
	at com.coveo.spillway.storage.RedisStorage.addAndGet(RedisStorage.java:112)
	at com.coveo.spillway.Spillway.getExceededLimits(Spillway.java:215)
	at com.coveo.spillway.Spillway.tryCall(Spillway.java:154)
	at com.coveo.spillway.Spillway.tryCall(Spillway.java:142)
	at io.seqera.wave.ratelimit.impl.SpillwayRateLimiter.acquirePull(SpillwayRateLimiter.groovy:84)

solved it by injecting the JedisPool in SpillWayStorageFactory

[munishchouhan]

Tested successfully with local redis and elasticcache redis with ssl and auth