Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage report to build #661

Merged
merged 12 commits into from
Oct 2, 2024
Merged

Add code coverage report to build #661

merged 12 commits into from
Oct 2, 2024

Conversation

pditommaso
Copy link
Contributor

This PR adds the jacoco plugin to create code coverage reports

Signed-off-by: Paolo Di Tommaso <[email protected]>
@pditommaso pditommaso marked this pull request as draft September 30, 2024 08:32
@pditommaso
Copy link
Contributor Author

@munishchouhan can you have a look how to grab the code cov report file and include in the CI build download page?

@pditommaso
Copy link
Contributor Author

This may be useful. Credits @swampie

@munishchouhan
Copy link
Member

@munishchouhan can you have a look how to grab the code cov report file and include in the CI build download page?

ok sure

@munishchouhan munishchouhan self-assigned this Sep 30, 2024
@munishchouhan
Copy link
Member

testing here
munishchouhan/jacoco-playground#1

@munishchouhan
Copy link
Member

code coverage is getting printed in the action console, but not getting commented in PR
I am trying different GH token to see if it is permission issue
Screenshot 2024-10-02 at 14 51 20

@pditommaso
Copy link
Contributor Author

It would be enough to have the coverage report downloadable, even in the tests one

@munishchouhan
Copy link
Member

code coverage report is successfully published
Screenshot 2024-10-02 at 15 40 18

Screenshot 2024-10-02 at 15 40 05

@munishchouhan munishchouhan marked this pull request as ready for review October 2, 2024 13:41
@munishchouhan
Copy link
Member

It would be enough to have the coverage report downloadable, even in the tests one

@pditommaso done

@pditommaso
Copy link
Contributor Author

Awesome

@pditommaso pditommaso merged commit 8f3de2a into master Oct 2, 2024
4 checks passed
@pditommaso pditommaso deleted the add-codecov branch October 2, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants