Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve container credentials retrieval using workflow compute environment #5

Conversation

munishchouhan
Copy link
Member

This PR will add support to retrieve credentials for workflow compute
Related to seqeralabs/wave#223

@pditommaso pditommaso merged commit 1b1f694 into master Sep 28, 2023
2 checks passed
@munishchouhan
Copy link
Member Author

@pditommaso please release wave-api new version

@pditommaso
Copy link
Contributor

it should be possible to use the version in master for dev, shouldn't it?

@munishchouhan
Copy link
Member Author

sorry, I don't understand
the tests in this PR seqeralabs/wave#303 are failing
because the current WAVE-API doesn't contain towerWorkflowId
so to make the tests pass, I need a new version
or should I make an RC release?

@pditommaso
Copy link
Contributor

Fair enough 6ef7e24

Tho, you should be able to test it locally using includeBuild

@munishchouhan
Copy link
Member Author

I already tested it locally with this PR

@munishchouhan munishchouhan deleted the Improve-container-credentials-retrieval-using-workflow-compute-environment branch October 11, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants