Remove references to redisson.* properties
#283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for seqera-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This might be unrelated, but I've just noticed that RedissonService, does rely on |
justinegeffen
added
1. Editor review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the next Enterprise version,
redisson.*properties will be deprecated./redisson/*references for the AWS parameter store withTOWER_REDIS_*.redisson.*references for thetower.ymlwithTOWER_REDIS_*. SettingTOWER_REDIS_*values directly in the YAML file (for example,TOWER_REDIS_URL: redis://...) intower.ymlis feasible.In fact, the tweak could be backported to previous versions, as the
TOWER_REDIS_*placeholders were always the source of truth. I doubt any Enterprise users were settingredisson.*properties directly, because the H8 2nd-level cache config doesn't know about them and the application would fail to start if they are not properly set.