Properly invalidates internal unions cache after bookmark

[patrickdalla]

Properly invalidates internal unions cache after bookmark deletion and creation.

Closes #2311.

[lfcnassif]

Thanks @patrickdalla. Was this opened as draft intentionally?

[patrickdalla]

No. For some reason github only shows a button to open as draft when I create a PR. I thought it would be some rule you as PM configured, or maybe a new rule from github. So I created as draft, but there is no more updates. Em seg., 26 de ago. de 2024, 12:06, Luis Filipe Nassif < ***@***.***> escreveu:

…

Thanks @patrickdalla <https://github.com/patrickdalla>. Was this opened as draft intentionally? — Reply to this email directly, view it on GitHub <#2312 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG247S3WOMVHXLQYR7DLSCLZTNHB7AVCNFSM6AAAAABNEDDHICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQGU3DAMBXHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[lfcnassif]

I didn't create any related rule, I think github shows the last option used by the developer. Thanks @patrickdallla.

[lfcnassif]

By the way, are those internal bookmark caches helpful in practice? Did you have noticiable performance bottlenecks that were fixed by them?

[patrickdalla]

There wasn't a bottleneck. This specific "cache" is just a variable with the result of the union of all bookmarks bitmaps that I use to check for items with no bookmarks.
It was just a code execution that I thought at implementation time it could be avoided to be repeated as every user filter change would run it again, although bookmark may not change.

[lfcnassif]

Sorry for my delay, thank you @patrickdalla for this fix!