Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use thumbnails from "media_hash_thumbnail" table (#2031). #2032

Closed
wants to merge 5 commits into from

Conversation

wladimirleite
Copy link
Member

Closes #2031.

@wladimirleite
Copy link
Member Author

Added other minor fixes and improvements related to WhatsApp generated HTML.

@wladimirleite
Copy link
Member Author

I created this PR just to address #2031.
However, while working on #2030, I realized that there may be some merging conflicts between them.
And the main problem is that I started to use two phones to check #2030 (initially I had only a WhatsApp database), comparing parser results with actual messages displayed on the devices. And there are differences that were solved by #2031, but I am not seeing them in #2030.
So I am closing this PR and will create a new one, which will handle both issues (and maybe #1923) together.

@wladimirleite wladimirleite deleted the #2031_WA_MediaHashThumbnail branch December 28, 2023 11:03
@lfcnassif
Copy link
Member

Hi @wladimirleite! I can merge #1920 to avoid more merge conflicts with the improvements you are working on. I detected just very minor differences with master, so I think it's safe and I can take a closer look at them later. What do you think?

@lfcnassif
Copy link
Member

PS: I saw you already pushed a few commits, so not sure if it will help.

@wladimirleite
Copy link
Member Author

Please, do that if you can.
I can stop commiting and reverse merge with the master after you merge #1920.
This should avoid more conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract more thumbnails from WhatsApp databases
2 participants