Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1857 complement #1995

Merged
merged 7 commits into from
Nov 23, 2023
Merged

#1857 complement #1995

merged 7 commits into from
Nov 23, 2023

Conversation

lfcnassif
Copy link
Member

Complement to #1857.

  1. Populate SHARED_HASHES property just if shared flag is true and totalDownloaded > 0.
  2. Create automatic bookmark for shared files found in the case.

@lfcnassif lfcnassif mentioned this pull request Nov 23, 2023
Merged
@lfcnassif
Copy link
Member Author

I did tests earlier (before a long meeting) and changed SD contained hashes artificially to match hashes of sample multimedia files I have here. Automatic bookmark and References tabs are working fine, so I'm merging.

@lfcnassif lfcnassif merged commit 875a42c into master Nov 23, 2023
2 checks passed
@lfcnassif lfcnassif deleted the #1857_complement branch November 23, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lfcnassif