Merge pull request #2382 from sepinf-inc/#2381_FixAudioReport

Disable audio transcription if initialization fails when creating reports (#2381)
sepinf-inc · Dec 12, 2024 · ac876db · ac876db
2 parents cc119ae + e98d8f3
commit ac876db
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 10 deletions.
diff --git a/iped-engine/src/main/java/iped/engine/task/transcript/RemoteTranscriptionTask.java b/iped-engine/src/main/java/iped/engine/task/transcript/RemoteTranscriptionTask.java
@@ -56,6 +56,8 @@ public class RemoteTranscriptionTask extends AbstractTranscriptTask {
 
     private static AtomicBoolean statsPrinted = new AtomicBoolean();
 
+    private static volatile AtomicBoolean init = new AtomicBoolean();
+
     private static long lastUpdateServersTime = 0;
 
     private static class Server {
@@ -81,7 +83,7 @@ public void init(ConfigurationManager configurationManager) throws Exception {
 
         super.init(configurationManager);
 
-        if (!this.isEnabled()) {
+        if (!isEnabled()) {
             return;
         }
 
@@ -115,8 +117,21 @@ public void init(ConfigurationManager configurationManager) throws Exception {
             return;
         }
 
-        requestServers(true);
-
+        synchronized (init) {
+            if (!init.get()) {
+                try {
+                    requestServers(true);
+                } catch (Exception e) {
+                    if (hasIpedDatasource()) {
+                        transcriptConfig.setEnabled(false);
+                        logger.warn("Could not initialize remote transcription. Task disabled.");
+                    } else {
+                        throw e;
+                    }
+                }
+                init.set(true);
+            }
+        }
     }
 
     private static synchronized void requestServers(RemoteTranscriptionTask task, boolean now) throws IOException {
@@ -163,7 +178,7 @@ private void requestServers(boolean now) throws IOException {
     @Override
     public void finish() throws Exception {
         super.finish();
-        if (!statsPrinted.getAndSet(true)) {
+        if (isEnabled() && !statsPrinted.getAndSet(true)) {
             int numWorkers = this.worker.manager.getNumWorkers();
             DecimalFormat df = new DecimalFormat();
             logger.info("Time spent to send audios: {}s", df.format(audioSendingTime.get() / (1000 * numWorkers)));

diff --git a/iped-engine/src/main/java/iped/engine/task/transcript/Wav2Vec2TranscriptTask.java b/iped-engine/src/main/java/iped/engine/task/transcript/Wav2Vec2TranscriptTask.java
@@ -7,6 +7,7 @@
 import java.io.InputStreamReader;
 import java.util.concurrent.LinkedBlockingDeque;
 import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
 
 import org.apache.commons.lang3.SystemUtils;
 import org.apache.logging.log4j.Level;
@@ -42,6 +43,8 @@ public class Wav2Vec2TranscriptTask extends AbstractTranscriptTask {
 
     protected static volatile Level logLevel = Level.forName("MSG", 250);
 
+    private static volatile AtomicBoolean init = new AtomicBoolean();
+
     static class Server {
         Process process;
         BufferedReader reader;
@@ -68,7 +71,7 @@ public void init(ConfigurationManager configurationManager) throws Exception {
 
         super.init(configurationManager);
 
-        if (!this.isEnabled()) {
+        if (!isEnabled()) {
             return;
         }
 
@@ -85,11 +88,26 @@ public void init(ConfigurationManager configurationManager) throws Exception {
 
         if (!deque.isEmpty())
             return;
-
-        Server server;
-        int device = 0;
-        while ((server = startServer(device++)) != null) {
-            deque.add(server);
+
+        synchronized (init) {
+            if (!init.get()) {
+                try {
+                    Server server;
+                    int device = 0;
+                    while ((server = startServer(device++)) != null) {
+                        deque.add(server);
+                    }
+
+                } catch (Exception e) {
+                    if (hasIpedDatasource()) {
+                        transcriptConfig.setEnabled(false);
+                        logger.warn("Could not initialize audio transcription. Task disabled.");
+                    } else {
+                        throw e;
+                    }
+                }
+                init.set(true);
+            }
         }
 
         logLevel = Level.DEBUG;