Skip to content

Commit

Permalink
Release try with tag
Browse files Browse the repository at this point in the history
  • Loading branch information
sepich committed Nov 19, 2023
1 parent 4e28dca commit 2a18470
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ jobs:
- name: Release
uses: softprops/action-gh-release@v1
if: startsWith(github.ref, 'refs/tags/') # Release requires tag
with:
name: ${{ steps.meta.outputs.version }}
draft: true
files: thanos-kit*.zip
generate_release_notes: true

Expand All @@ -60,7 +60,6 @@ jobs:
push: true
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
build-args: |
VER=${{ steps.meta.outputs.version }}
build-args: VER=${{ steps.meta.outputs.version }}
cache-from: type=gha
cache-to: type=gha,mode=max
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,7 @@ build: ## Build binaries with version set

docker: ## Builds 'thanos-kit' docker with no tag
@docker build -t "thanos-kit" .

tag: ## Tags commit to trigger GH Release
git tag ${VER}
git push --tags

0 comments on commit 2a18470

Please sign in to comment.