improvements for docker build

[multiwave]

I used your Dockerfile as a base, key changes:

• to run it you now use REDIS_URL instead of 3 env vars, and HTTP_PATH env var is now optional (default being '/qless') example: docker run -e REDIS_URL="redis://127.0.0.1:6379/0" $IMG_NAME bundle exec rackup qless.ru -o0.0.0.0 -p 5678
• Dockerfile is according to dockers best practices (fewer RUN commands)
• final image is about 110 MiB smaller than ubuntu based prior version
• jquery is no longer loaded from CDN (in our environment that doesn't work, client computers interacting with cluster have no internet access) bug Do not use CDN versions of JavaScript scripts qless#244 references that problem too

I hope some of those changes make into your master.

[b4hand]

You can turn this whole block into:

gui_path = ENV.fetch('HTTP_PATH', '/qless')

[weiser]

@multiwave thanks for sending the submission!

I like the idea of using REDIS_URL. I think, though, that the user should be able to provide either REDIS_URL or the other env vars because otherwise we'll introduce breaking change to groups which upgrade this without noticing the env var change.

So, I'm happy to merge this provided:

1. README.md is updated to show how to run the container using either REDIS_URL or the other env vars.
2. Update the implementation of qless.ru to use either REDIS_URL or the other env vars.

[weiser]

I think that this change should happen in seomoz/qless, not here. Qless, here, can be bumped once seomoz/qless has updated.

[multiwave]

I guess it should be okay now, about the javascript patch - I will keep it here, as I cannot wait for upstream to fix it. But it is easy to remove, do not merge local_js.patch and skip the last lines in Dockerfile.

[weiser]

Re: the java script patch. Could you please add a reference to the qless issue that is necessitating the JS patch so we know when the patch can be removed and qless updated?

[multiwave]

Sorry for the late response, didn't realize there was feedback. I have now referenced the javascript Issue in comment right above the patch. But when they fixed it upstream the patch will fail, therefore Dockerfile build fails, therefore you know it can be removed ;)

[weiser]

@multiwave thanks for getting back to us on this. Sorry I'm so late at getting this (I was on vacation).

Merging.

Thanks, again, for contributing,