Use file name / foder name for unknown tag retrieval. #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When taglib get empty or null title from file/album, use file name or folder name as the tag_title field. It could be confuse to user, but at leaset it is better than tracks/albums can't be search in ID3 mode API.
|
interesting, i think i'd need to weigh up the pros and cons here. this is what the subsonic "browse by folder" mode is for. have you tried that? |
|
Yes, I know. However, the PC client
I don't think this PR has any drawbacks. It supplements the missing song information in ID3 mode, turning blank titles and Unknown Album into understandable information. At the same time, it does not change the behavior in "browser by folder" mode. I have been using it for two months and think this is a very good improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When taglib cannot retrieve the title of the media or the title of the album, use the filename as the track name and the folder name as the album name.
I have a lot of music downloaded from YouTube, which doesn't have recognizable media metadata. After scanning with gonic, all of them turn into empty titles and unknown albums, making it difficult for me to distinguish the music. For example, like this:
These pieces of music without metadata should be manually managed by the user using filenames and folders. In this way, using the filename and folder as the title and album name is reasonable. For example, like this: (the file is named
aino.opusunder foldermiku)