Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -playlists-relative option #537

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

0chroma
Copy link

@0chroma 0chroma commented Sep 7, 2024

Fixes #529

Improves portability between machines by optionally making file paths relative to the playlist

feedback welcome! it's my first time writing go

@sentriz
Copy link
Owner

sentriz commented Sep 7, 2024

hm I wonder do we need the config option at all? can we just allow relative paths? joining on the basedir if the playlist line doesn't look absolute with no leading slash

@0chroma
Copy link
Author

0chroma commented Sep 7, 2024

the option mostly determines if the playlist is written with absolute or relative paths, I modified the reader so it does exactly what you described regardless of config option

@0chroma
Copy link
Author

0chroma commented Sep 8, 2024

If you'd like I can remove the config check during writes from the PR, but I think there's a lot of situations where absolute paths would still make sense (ie having playlists and music on separate volumes)

@0chroma
Copy link
Author

0chroma commented Oct 16, 2024

heya, just checking in. Let me know if you'd like this merged in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: better playlist portability
2 participants