much needed cleanup #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majormoses
force-pushed
the
feature/drop-eol-rubies
branch
from
1c184dd
to
5cec74a
Compare
This includes: - dropping EOL ruby versions - bumping dependencies (some address CVEs) - appeasing or disabling new cops - removed codelimate dep as its not used anymore - removed some old badges For a more complete/detailed list see the changelog. Signed-off-by: Ben Abrams <[email protected]>
majormoses
force-pushed
the
feature/drop-eol-rubies
branch
from
5cec74a
to
71b6fe9
Compare
jaredledvina
approved these changes
Feb 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes:
For a more complete/detailed list see the changelog.
Signed-off-by: Ben Abrams [email protected]
Pull Request Checklist
General
Update Changelog following the conventions laid out on Our CHANGELOG Guidelines
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
Purpose
Routine cleanup
Known Compatibility Issues
There are several breaking changes, refer to changelog.