Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependency of sensu-plugin to 2.x #58

Merged
merged 1 commit into from
Jan 12, 2018

Conversation

majormoses
Copy link
Member

This is a breaking change, to keep filtering of occurences it requires you to add occurences to the list of filters associated with the handler.

Signed-off-by: Ben Abrams [email protected]

Pull Request Checklist

General

  • Update Changelog following the conventions laid out on Keep A Changelog

  • Update README with any necessary configuration snippets

  • Binstubs are created if needed

  • RuboCop passes

  • Existing tests pass

Purpose

Disabling built in occurences, accidentally fixes #52

Known Compatablity Issues

Anyone who was previously using the occurences attribute needs to specify that this handler should use the occurences filter.

This is a breaking change, to keep filtering of occurences it requires you to add `occurences` to the list of filters associated with the handler.

Signed-off-by: Ben Abrams <[email protected]>
Copy link
Contributor

@eheydrick eheydrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@majormoses majormoses merged commit 4c559a0 into master Jan 12, 2018
@majormoses
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event filtering in sensu-plugin is deprecated causing the handler not to always work
2 participants