-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple updates #59
Multiple updates #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Are the tests known to fail for this?
Hmm I will look into this later, not sure why thats bricking from a quick look. This is why we have tests! |
cddf5bb
to
87d104c
Compare
check-stale-results
when api config is not present- improving error message in `check-stale-results` when api config is not present - updating `rubocop` dep and appeasing the cops - updating `yard` dep - updating `sensu-plugin` dep - added slack badge - removed gemnasium badge CVE's addressed: - https://nvd.nist.gov/vuln/detail/CVE-2017-17042 - https://nvd.nist.gov/vuln/detail/CVE-2017-8418 Breaking Changes: - removed ruby `< 2.3` support Signed-off-by: Ben Abrams <[email protected]>
87d104c
to
2e83ba6
Compare
@jaredledvina I could not figure out why it was complaining until I bumped the min ruby version and switched to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-reviewed, LGTM!
Multiple Updates:
check-stale-results
when api config is not presentrubocop
dep and appeasing the copsyard
depsensu-plugin
depCVE's addressed:
Breaking Changes:
< 2.3
supportSigned-off-by: Ben Abrams [email protected]
Pull Request Checklist
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
Purpose
Help user understand what the error means and how they can fix it.
Known Compatibility Issues