Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple updates #59

Conversation

majormoses
Copy link
Member

@majormoses majormoses commented Jun 30, 2018

Multiple Updates:

  • improving error message in check-stale-results when api config is not present
  • updating rubocop dep and appeasing the cops
  • updating yard dep
  • updating sensu-plugin dep
  • removed gemnasium badge
  • added slack badge

CVE's addressed:

Breaking Changes:

  • removed ruby < 2.3 support

Signed-off-by: Ben Abrams [email protected]

Pull Request Checklist

General

  • Update Changelog following the conventions laid out here

  • Update README with any necessary configuration snippets

  • Binstubs are created if needed

  • RuboCop passes

  • Existing tests pass

Purpose

Help user understand what the error means and how they can fix it.

Known Compatibility Issues

Copy link
Member

@jaredledvina jaredledvina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Are the tests known to fail for this?

@majormoses
Copy link
Member Author

Hmm I will look into this later, not sure why thats bricking from a quick look. This is why we have tests!

@majormoses majormoses force-pushed the feature/improve-error-message-when-settings.api-key-does-not-exist branch from cddf5bb to 87d104c Compare July 8, 2018 19:12
@majormoses majormoses changed the title improving error message in check-stale-results when api config is not present Multiple updates Jul 8, 2018
- improving error message in `check-stale-results` when api config is not present
- updating `rubocop` dep and appeasing the cops
- updating `yard` dep
- updating `sensu-plugin` dep
- added slack badge
- removed gemnasium badge

CVE's addressed:
- https://nvd.nist.gov/vuln/detail/CVE-2017-17042
- https://nvd.nist.gov/vuln/detail/CVE-2017-8418

Breaking Changes:
- removed ruby `< 2.3` support

Signed-off-by: Ben Abrams <[email protected]>
@majormoses majormoses force-pushed the feature/improve-error-message-when-settings.api-key-does-not-exist branch from 87d104c to 2e83ba6 Compare July 8, 2018 19:20
@majormoses
Copy link
Member Author

majormoses commented Jul 8, 2018

@jaredledvina I could not figure out why it was complaining until I bumped the min ruby version and switched to the <<~HEREDOC tilde style which also is better formatting in my opinion. I decided to just rip the band-aide off and do some much needed cleaning up in this plugin. Sorry in advance for the scope creep.

Copy link
Member

@jaredledvina jaredledvina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed, LGTM!

@majormoses
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api.json settings not found
2 participants