some much needed cleanup #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majormoses
added
Type: Enhancement
Impact: Breaking Change
Type: Security
Status: Needs Review
dependencies
Addressed CVEs: - CVE-2017-8418 - CVE-2017-17042 Breaking Changes: - use `sensu-plugin` 2.x - removed support for ruby < 2.3 Misc Changes: - appeased the cops Signed-off-by: Ben Abrams <[email protected]>
majormoses
force-pushed
the
feature/cleanup
branch
from
69c55e4
to
c97b2b3
Compare
|
Looks like I am forced to self merge without review 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Abrams [email protected]
Pull Request Checklist
General
Update Changelog following the conventions laid out at here
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
Purpose
Addressed CVEs:
Misc Changes:
sensu-plugin2.xKnown Compatibility Issues
sensu-plugin2.x