Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename kafka to kafka2 (fixes #4) #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

maoe
Copy link

@maoe maoe commented Jan 29, 2020

Pull Request Checklist

This PR is a bug fix for #4.

General

  • Update Changelog following the conventions laid out here

  • Update README with any necessary configuration snippets: N/A

  • Binstubs are created if needed: N/A

  • RuboCop passes

  • Existing tests pass

Purpose

check-kafka-ping and metrics-kafka-http are broken because they still require 'sense-plugins-kafka' and include CommonKafkaalthough the file/module were renamed tosensu-plugins-kafka2andCommonKafka2` respectively. This PR fixes it.

Known Compatibility Issues

No known issues.

@maoe maoe changed the title Kafka2 Rename kafka to kafka2 (fixes #4) Jan 29, 2020
@maoe
Copy link
Author

maoe commented Jan 29, 2020

RuboCop passes except for Missing magic comment # frozen_string_literal: true in various places.

% bundle exec rake rubocop
Running RuboCop...
Inspecting 15 files
C..CCCCCCC.....

Offenses:

Gemfile:1:1: C: Missing magic comment # frozen_string_literal: true.
source 'https://rubygems.org'
^
lib/sensu-plugins-kafka2.rb:1:1: C: Missing magic comment # frozen_string_literal: true.
require 'sensu-plugins-kafka2/common_kafka'
^
lib/sensu-plugins-kafka2/common_kafka.rb:1:1: C: Missing magic comment # frozen_string_literal: true.
module CommonKafka2
^
lib/sensu-plugins-kafka2/version.rb:1:1: C: Missing magic comment # frozen_string_literal: true.
module SensuPluginsKafka2
^
bin/check-topics-name.rb:1:1: C: Missing magic comment # frozen_string_literal: true.
#! /usr/bin/env ruby
^
bin/check-kafka-ping.rb:1:1: C: Missing magic comment # frozen_string_literal: true.
#! /usr/bin/env ruby
^
bin/check-topic.rb:1:1: C: Missing magic comment # frozen_string_literal: true.
#! /usr/bin/env ruby
^
bin/metrics-kafka-http.rb:1:1: C: Missing magic comment # frozen_string_literal: true.
#! /usr/bin/env ruby
^

15 files inspected, 8 offenses detected
RuboCop failed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant