fixed conflicting short options for -n in check-cloudwatch-metric.rb

Signed-off-by: Ben Abrams <[email protected]>
sensu-plugins · Aug 12, 2017 · e212c97 · e212c97
1 parent ecbe55e
commit e212c97
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@ This CHANGELOG follows the format listed at [Keep A Changelog](http://keepachang
 
 ### Fixed
 - check-cloudwatch-metric.rb, check-cloudwatch-composite-metric.rb: fixed defaults to work (@majormoses)
+- check-cloudwatch-metric.rb: short option `-n` was conflicting with `no_data_ok` and `namespace` as `check-cloudwatch-composite-metric.rb` uses `-O` I opted for that for consistency (@majormoses)
 
 ### Changed
 - check-cloudwatch-metric.rb, check-cloudwatch-composite-metric.rb: `self.parse_dimensions` and `dimension_string` were the same in both checks This fix was common mamong both checks so I moved it into the module

diff --git a/bin/check-cloudwatch-metric.rb b/bin/check-cloudwatch-metric.rb
@@ -95,7 +95,7 @@ class CloudWatchMetricCheck < Sensu::Plugin::Check::CLI
          default: 'greater'
 
   option :no_data_ok,
-         short: '-n',
+         short: '-O',
          long: '--allow-no-data',
          description: 'Returns ok if no data is returned from the metric',
          boolean: true,