[CLNP-5043] Add unit tests for improved MessageSearch module #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisallo
reviewed
Oct 9, 2024
| result.current.actions.setQueryInvalid(); | ||
| }); | ||
|
|
||
| expect(result.current.state.isInvalid).toBe(true); |
There was a problem hiding this comment.
While I was reading the code and the test, it was a bit confusing for me what isInvalid means because both a channel and a query could go invalid. Do you mind changing the name to isQueryInvalid for clarity?
| result.current.actions.setCurrentChannel({ url: 'test-channel' } as any); | ||
| await waitFor(() => { | ||
| expect(result.current.state.currentChannel).toEqual({ url: 'test-channel' }); | ||
| expect(result.current.state.initialized).toBe(true); |
There was a problem hiding this comment.
It makes more sense to me to make sure the other states such as loading and isInvalid unchanged. It would help finding some regression before the thing could go into trouble imho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sendbird.atlassian.net/browse/CLNP-5043
Two things are handled based on what I mentioned in https://sendbird.atlassian.net/wiki/spaces/UIKitreact/pages/2511765635/UIKit+React+new+State+Management+Method+Proposal#4.1-Unit-Test
useMessageSearchhook and newMessageSearchProviderMessageSearchUIcomponentSo the MessageSearch module test coverage has been changed
from
File --------------------------------------------------| % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
to
note that it used to be like 0%, but now the test coverage of the newly added files is almost 100%; green 🟩.
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.This is a reminder of what we look for before merging your code.