Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc 1.0.43 #69

Merged
merged 8 commits into from
Oct 10, 2024
Merged

Rc 1.0.43 #69

merged 8 commits into from
Oct 10, 2024

Conversation

semuadmin
Copy link
Contributor

@semuadmin semuadmin commented Oct 8, 2024

pynmeagps Pull Request Template

Description

  1. Add provision for user-defined payload definition dictionary, supplementing the existing NMEA_PAYLOADS_GET and NMEA_PAYLOADS_GET_PROP dictionaries. Format should mirror that used in NMEA_PAYLOADS_GET. Can be used for proprietary product development purposes or for standard payload definitions which are not yet in the public domain.
  2. Drop active support for Python 3.8 - now End of Life as at October 2024.

Fixes: #68

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

  • Add stream test for user-defined payload definitions

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.md).
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 8, 2024
@semuadmin semuadmin added this to the RC 1.0.43 milestone Oct 8, 2024
@semuadmin semuadmin self-assigned this Oct 8, 2024
@semuadmin semuadmin requested a review from a team October 8, 2024 07:31
@semuadmin semuadmin marked this pull request as draft October 8, 2024 07:34
@semuadmin semuadmin marked this pull request as ready for review October 9, 2024 21:25
@semuadmin semuadmin merged commit 360935b into master Oct 10, 2024
@semuadmin semuadmin deleted the RC-1.0.43 branch October 10, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants