fix(firehose-client): fix client chain specification

[suchapalaver]

BACK-53

A way to check this is the stream_beacon example should work now (you need an API key though!).

[linear]

BACK-53 `veemon/firehose-client`: fix client for use with API keys

[github-actions]

🤖 Cargo Audit Report 🤖

Crate: object_store
Version: 0.9.1
Title: Apache Arrow Rust Object Store: AWS WebIdentityToken exposure in log files
Date: 2024-07-23
ID: RUSTSEC-2024-0358
URL: https://rustsec.org/advisories/RUSTSEC-2024-0358
Severity: 3.8 (low)
Solution: Upgrade to >=0.10.2
Dependency tree:
object_store 0.9.1
└── flat-head 0.1.0

Crate: ansi_term
Version: 0.12.1
Warning: unmaintained
Title: ansi_term is Unmaintained
Date: 2021-08-18
ID: RUSTSEC-2021-0139
URL: https://rustsec.org/advisories/RUSTSEC-2021-0139
Dependency tree:
ansi_term 0.12.1
└── trin-utils 0.1.1-alpha.1
└── ethportal-api 0.2.2
├── trin-validation 0.1.0
│ ├── header_accumulator 0.1.0
│ │ └── flat-head 0.1.0
│ └── flat-head 0.1.0
├── sf-protos 0.1.0
│ ├── header_accumulator 0.1.0
│ ├── forrestrie 0.1.0
│ ├── flat-head 0.1.0
│ ├── firehose-client 0.1.0
│ │ └── forrestrie 0.1.0
│ └── decoder 0.1.1
│ ├── header_accumulator 0.1.0
│ └── flat-head 0.1.0
├── header_accumulator 0.1.0
└── forrestrie 0.1.0

Crate: atty
Version: 0.2.14
Warning: unmaintained
Title: atty is unmaintained
Date: 2024-09-25
ID: RUSTSEC-2024-0375
URL: https://rustsec.org/advisories/RUSTSEC-2024-0375
Dependency tree:
atty 0.2.14
└── trin-utils 0.1.1-alpha.1
└── ethportal-api 0.2.2
├── trin-validation 0.1.0
│ ├── header_accumulator 0.1.0
│ │ └── flat-head 0.1.0
│ └── flat-head 0.1.0
├── sf-protos 0.1.0
│ ├── header_accumulator 0.1.0
│ ├── forrestrie 0.1.0
│ ├── flat-head 0.1.0
│ ├── firehose-client 0.1.0
│ │ └── forrestrie 0.1.0
│ └── decoder 0.1.1
│ ├── header_accumulator 0.1.0
│ └── flat-head 0.1.0
├── header_accumulator 0.1.0
└── forrestrie 0.1.0

Crate: dotenv
Version: 0.15.0
Warning: unmaintained
Title: dotenv is Unmaintained
Date: 2021-12-24
ID: RUSTSEC-2021-0141
URL: https://rustsec.org/advisories/RUSTSEC-2021-0141
Dependency tree:
dotenv 0.15.0
└── flat-head 0.1.0

Crate: proc-macro-error
Version: 1.0.4
Warning: unmaintained
Title: proc-macro-error is unmaintained
Date: 2024-09-01
ID: RUSTSEC-2024-0370
URL: https://rustsec.org/advisories/RUSTSEC-2024-0370
Dependency tree:
proc-macro-error 1.0.4
├── validator_derive 0.13.0
│ └── validator 0.13.0
│ └── ethportal-api 0.2.2
│ ├── trin-validation 0.1.0
│ │ ├── header_accumulator 0.1.0
│ │ │ └── flat-head 0.1.0
│ │ └── flat-head 0.1.0
│ ├── sf-protos 0.1.0
│ │ ├── header_accumulator 0.1.0
│ │ ├── forrestrie 0.1.0
│ │ ├── flat-head 0.1.0
│ │ ├── firehose-client 0.1.0
│ │ │ └── forrestrie 0.1.0
│ │ └── decoder 0.1.1
│ │ ├── header_accumulator 0.1.0
│ │ └── flat-head 0.1.0
│ ├── header_accumulator 0.1.0
│ └── forrestrie 0.1.0
├── alloy-sol-macro-expander 0.7.7
│ └── alloy-sol-macro 0.7.7
│ └── alloy-sol-types 0.7.7
│ ├── alloy-rpc-types-eth 0.1.4
│ │ ├── reth-primitives-traits 1.0.1
│ │ │ ├── reth-trie-common 1.0.1
│ │ │ │ ├── reth-primitives 1.0.1
│ │ │ │ │ ├── sf-protos 0.1.0
│ │ │ │ │ └── decoder 0.1.1
│ │ │ │ └── decoder 0.1.1
│ │ │ └── reth-primitives 1.0.1
│ │ └── alloy-rpc-types 0.1.4
│ │ └── reth-primitives 1.0.1
│ └── alloy-rpc-types 0.1.0
│ ├── reth-rpc-types 0.2.0-beta.5
│ │ └── ethportal-api 0.2.2
│ ├── alloy-rpc-types-trace 0.1.0
│ │ └── reth-rpc-types 0.2.0-beta.5
│ └── alloy-rpc-types-engine 0.1.0
│ └── reth-rpc-types 0.2.0-beta.5
└── alloy-sol-macro 0.7.7

Crate: atty
Version: 0.2.14
Warning: unsound
Title: Potential unaligned read
Date: 2021-07-04
ID: RUSTSEC-2021-0145
URL: https://rustsec.org/advisories/RUSTSEC-2021-0145

warning: 5 allowed warnings found

(Empty means OK! 👍)

[suchapalaver]

This is the main fix.

[gusinacio]

I understand all the changes here:

• Using tracing
• Returning a result over panicking
• Renaming variables
• Updating client chain spec

For future reviews, each of these could be a PR.

LGTM