Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove the client and post-merge protobufs from veemon #65

Merged
merged 2 commits into from
Nov 28, 2024
Merged

chore: remove the client and post-merge protobufs from veemon #65

merged 2 commits into from
Nov 28, 2024

Conversation

suchapalaver
Copy link
Contributor

@suchapalaver suchapalaver commented Nov 28, 2024 •
edited
Loading

Preparation for the next life without forrestrie

BACK-176

@linear Linear
Copy link

linear bot commented Nov 28, 2024

BACK-172 Remove `forrestrie` from `veemon`

anirudh

This will also include removing forrestrie-examples, firehose-client, the Beacon protobuffers code from forrestrie will go to a new repo called beacon-protos, code related to firehose gRPC client in Rust will go to a repo called firehose-rs. forrestrie and forrestrie-examples will go to a workspace repo called vee-post-merge.

@suchapalaver suchapalaver force-pushed the joseph/back-172-remove-forrestrie-from-veemon branch from 8fd72b4 to 313defb Compare November 28, 2024 16:29
@suchapalaver suchapalaver force-pushed the joseph/back-172-remove-forrestrie-from-veemon branch from 2c06a3b to 991e53a Compare November 28, 2024 16:34
@suchapalaver suchapalaver changed the title chore: remove forrestrie from veemon chore: remove the client, post-merge protobufs, and forrestrie from veemon Nov 28, 2024
@suchapalaver suchapalaver self-assigned this Nov 28, 2024
@suchapalaver suchapalaver marked this pull request as ready for review November 28, 2024 16:41
@suchapalaver suchapalaver changed the title chore: remove the client, post-merge protobufs, and forrestrie from veemon chore: remove the client and post-merge protobufs from veemon Nov 28, 2024
gusinacio
gusinacio approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@suchapalaver suchapalaver merged commit bbc68a9 into main Nov 28, 2024
10 checks passed
@suchapalaver suchapalaver deleted the joseph/back-172-remove-forrestrie-from-veemon branch November 28, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusinacio gusinacio gusinacio approved these changes

Assignees

@suchapalaver suchapalaver

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suchapalaver @gusinacio