Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up inclusion proof #33

Merged
merged 8 commits into from
Nov 28, 2024

Conversation

gusinacio
Copy link
Contributor

No description provided.

Copy link

linear bot commented Oct 29, 2024

BACK-96 Clean up inclusion proof

Use Epoch instead of Vec

@gusinacio gusinacio force-pushed the gustavo/back-96-clean-up-inclusion-proof branch 4 times, most recently from 0883044 to 51b792f Compare November 5, 2024 01:08
@gusinacio gusinacio marked this pull request as ready for review November 5, 2024 01:08
Copy link
Member

@anirudh2 anirudh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed I was requested on this PR.

crates/header-accumulator/src/inclusion_proof.rs Outdated Show resolved Hide resolved
crates/header-accumulator/src/inclusion_proof.rs Outdated Show resolved Hide resolved
crates/header-accumulator/src/inclusion_proof.rs Outdated Show resolved Hide resolved
crates/header-accumulator/src/inclusion_proof.rs Outdated Show resolved Hide resolved
@gusinacio gusinacio force-pushed the gustavo/back-96-clean-up-inclusion-proof branch from 51b792f to b84093d Compare November 25, 2024 17:15
Copy link
Member

@anirudh2 anirudh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More proovens haha

crates/header-accumulator/src/inclusion_proof.rs Outdated Show resolved Hide resolved
crates/header-accumulator/src/inclusion_proof.rs Outdated Show resolved Hide resolved
crates/header-accumulator/src/inclusion_proof.rs Outdated Show resolved Hide resolved
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio gusinacio force-pushed the gustavo/back-96-clean-up-inclusion-proof branch from 6490dec to ca4fdf0 Compare November 26, 2024 18:40
Copy link
Member

@anirudh2 anirudh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Great work, Gustavo!

@suchapalaver suchapalaver merged commit dbc16cf into main Nov 28, 2024
7 checks passed
@suchapalaver suchapalaver deleted the gustavo/back-96-clean-up-inclusion-proof branch November 28, 2024 11:40
suchapalaver added a commit that referenced this pull request Nov 28, 2024
…us-test

chore(forrestrie): remove superfluous beacon block test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants