fix ci: miscellaneous chores and fixes #3

suchapalaver · 2024-10-15T00:19:29Z

BACK-36

cargo package imports
cargo clippy warnings
cargo fmt
protoc in CI tests
firehose client support (needed to convert forrestrie tests to examples)
convert tests into examples/
Update README and document using examples/
Convert firehose-client tests to examples/
Fix failing header-accumulator test

linear · 2024-10-15T00:19:32Z

BACK-34 `veemon`: Fix CI

See subissues

github-actions · 2024-10-16T18:40:25Z

🤖 Cargo Audit Report 🤖

Crate: object_store
Version: 0.9.1
Title: Apache Arrow Rust Object Store: AWS WebIdentityToken exposure in log files
Date: 2024-07-23
ID: RUSTSEC-2024-0358
URL: https://rustsec.org/advisories/RUSTSEC-2024-0358
Severity: 3.8 (low)
Solution: Upgrade to >=0.10.2
Dependency tree:
object_store 0.9.1
└── flat-head 0.1.0

Crate: ansi_term
Version: 0.12.1
Warning: unmaintained
Title: ansi_term is Unmaintained
Date: 2021-08-18
ID: RUSTSEC-2021-0139
URL: https://rustsec.org/advisories/RUSTSEC-2021-0139
Dependency tree:
ansi_term 0.12.1
└── trin-utils 0.1.1-alpha.1
└── ethportal-api 0.2.2
├── trin-validation 0.1.0
│ ├── header_accumulator 0.1.0
│ │ └── flat-head 0.1.0
│ └── flat-head 0.1.0
├── sf-protos 0.1.0
│ ├── header_accumulator 0.1.0
│ ├── forrestrie 0.1.0
│ ├── flat-head 0.1.0
│ ├── firehose-client 0.1.0
│ │ └── forrestrie 0.1.0
│ └── decoder 0.1.1
│ ├── header_accumulator 0.1.0
│ └── flat-head 0.1.0
└── header_accumulator 0.1.0

Crate: atty
Version: 0.2.14
Warning: unmaintained
Title: atty is unmaintained
Date: 2024-09-25
ID: RUSTSEC-2024-0375
URL: https://rustsec.org/advisories/RUSTSEC-2024-0375
Dependency tree:
atty 0.2.14
└── trin-utils 0.1.1-alpha.1
└── ethportal-api 0.2.2
├── trin-validation 0.1.0
│ ├── header_accumulator 0.1.0
│ │ └── flat-head 0.1.0
│ └── flat-head 0.1.0
├── sf-protos 0.1.0
│ ├── header_accumulator 0.1.0
│ ├── forrestrie 0.1.0
│ ├── flat-head 0.1.0
│ ├── firehose-client 0.1.0
│ │ └── forrestrie 0.1.0
│ └── decoder 0.1.1
│ ├── header_accumulator 0.1.0
│ └── flat-head 0.1.0
└── header_accumulator 0.1.0

Crate: dotenv
Version: 0.15.0
Warning: unmaintained
Title: dotenv is Unmaintained
Date: 2021-12-24
ID: RUSTSEC-2021-0141
URL: https://rustsec.org/advisories/RUSTSEC-2021-0141
Dependency tree:
dotenv 0.15.0
└── flat-head 0.1.0

Crate: proc-macro-error
Version: 1.0.4
Warning: unmaintained
Title: proc-macro-error is unmaintained
Date: 2024-09-01
ID: RUSTSEC-2024-0370
URL: https://rustsec.org/advisories/RUSTSEC-2024-0370
Dependency tree:
proc-macro-error 1.0.4
├── validator_derive 0.13.0
│ └── validator 0.13.0
│ └── ethportal-api 0.2.2
│ ├── trin-validation 0.1.0
│ │ ├── header_accumulator 0.1.0
│ │ │ └── flat-head 0.1.0
│ │ └── flat-head 0.1.0
│ ├── sf-protos 0.1.0
│ │ ├── header_accumulator 0.1.0
│ │ ├── forrestrie 0.1.0
│ │ ├── flat-head 0.1.0
│ │ ├── firehose-client 0.1.0
│ │ │ └── forrestrie 0.1.0
│ │ └── decoder 0.1.1
│ │ ├── header_accumulator 0.1.0
│ │ └── flat-head 0.1.0
│ └── header_accumulator 0.1.0
├── alloy-sol-macro-expander 0.7.7
│ └── alloy-sol-macro 0.7.7
│ └── alloy-sol-types 0.7.7
│ ├── alloy-rpc-types-eth 0.1.4
│ │ ├── reth-primitives-traits 1.0.1
│ │ │ ├── reth-trie-common 1.0.1
│ │ │ │ ├── reth-primitives 1.0.1
│ │ │ │ │ ├── sf-protos 0.1.0
│ │ │ │ │ └── decoder 0.1.1
│ │ │ │ └── decoder 0.1.1
│ │ │ └── reth-primitives 1.0.1
│ │ └── alloy-rpc-types 0.1.4
│ │ └── reth-primitives 1.0.1
│ └── alloy-rpc-types 0.1.0
│ ├── reth-rpc-types 0.2.0-beta.5
│ │ └── ethportal-api 0.2.2
│ ├── alloy-rpc-types-trace 0.1.0
│ │ └── reth-rpc-types 0.2.0-beta.5
│ └── alloy-rpc-types-engine 0.1.0
│ └── reth-rpc-types 0.2.0-beta.5
└── alloy-sol-macro 0.7.7

Crate: atty
Version: 0.2.14
Warning: unsound
Title: Potential unaligned read
Date: 2021-07-04
ID: RUSTSEC-2021-0145
URL: https://rustsec.org/advisories/RUSTSEC-2021-0145

warning: 5 allowed warnings found

(Empty means OK! 👍)

gusinacio · 2024-10-16T19:14:38Z

Hey, could you take a look at the audit? There are a few crates that need some updates.

🤖 Cargo Audit Report 🤖

Crate: object_store Version: 0.9.1 Title: Apache Arrow Rust Object Store: AWS WebIdentityToken exposure in log files Date: 2024-07-23 ID: RUSTSEC-2024-0358 URL: rustsec.org/advisories/RUSTSEC-2024-0358 Severity: 3.8 (low) Solution: Upgrade to >=0.10.2 Dependency tree: object_store 0.9.1 └── flat-head 0.1.0

Crate: ansi_term Version: 0.12.1 Warning: unmaintained Title: ansi_term is Unmaintained Date: 2021-08-18 ID: RUSTSEC-2021-0139 URL: rustsec.org/advisories/RUSTSEC-2021-0139 Dependency tree: ansi_term 0.12.1 └── trin-utils 0.1.1-alpha.1 └── ethportal-api 0.2.2 ├── trin-validation 0.1.0 │ ├── header_accumulator 0.1.0 │ │ └── flat-head 0.1.0 │ └── flat-head 0.1.0 ├── sf-protos 0.1.0 │ ├── header_accumulator 0.1.0 │ ├── forrestrie 0.1.0 │ ├── flat-head 0.1.0 │ ├── firehose-client 0.1.0 │ │ └── forrestrie 0.1.0 │ └── decoder 0.1.1 │ ├── header_accumulator 0.1.0 │ └── flat-head 0.1.0 └── header_accumulator 0.1.0

Crate: atty Version: 0.2.14 Warning: unmaintained Title: atty is unmaintained Date: 2024-09-25 ID: RUSTSEC-2024-0375 URL: rustsec.org/advisories/RUSTSEC-2024-0375 Dependency tree: atty 0.2.14 └── trin-utils 0.1.1-alpha.1 └── ethportal-api 0.2.2 ├── trin-validation 0.1.0 │ ├── header_accumulator 0.1.0 │ │ └── flat-head 0.1.0 │ └── flat-head 0.1.0 ├── sf-protos 0.1.0 │ ├── header_accumulator 0.1.0 │ ├── forrestrie 0.1.0 │ ├── flat-head 0.1.0 │ ├── firehose-client 0.1.0 │ │ └── forrestrie 0.1.0 │ └── decoder 0.1.1 │ ├── header_accumulator 0.1.0 │ └── flat-head 0.1.0 └── header_accumulator 0.1.0

Crate: dotenv Version: 0.15.0 Warning: unmaintained Title: dotenv is Unmaintained Date: 2021-12-24 ID: RUSTSEC-2021-0141 URL: rustsec.org/advisories/RUSTSEC-2021-0141 Dependency tree: dotenv 0.15.0 └── flat-head 0.1.0

Crate: proc-macro-error Version: 1.0.4 Warning: unmaintained Title: proc-macro-error is unmaintained Date: 2024-09-01 ID: RUSTSEC-2024-0370 URL: rustsec.org/advisories/RUSTSEC-2024-0370 Dependency tree: proc-macro-error 1.0.4 ├── validator_derive 0.13.0 │ └── validator 0.13.0 │ └── ethportal-api 0.2.2 │ ├── trin-validation 0.1.0 │ │ ├── header_accumulator 0.1.0 │ │ │ └── flat-head 0.1.0 │ │ └── flat-head 0.1.0 │ ├── sf-protos 0.1.0 │ │ ├── header_accumulator 0.1.0 │ │ ├── forrestrie 0.1.0 │ │ ├── flat-head 0.1.0 │ │ ├── firehose-client 0.1.0 │ │ │ └── forrestrie 0.1.0 │ │ └── decoder 0.1.1 │ │ ├── header_accumulator 0.1.0 │ │ └── flat-head 0.1.0 │ └── header_accumulator 0.1.0 ├── alloy-sol-macro-expander 0.7.7 │ └── alloy-sol-macro 0.7.7 │ └── alloy-sol-types 0.7.7 │ ├── alloy-rpc-types-eth 0.1.4 │ │ ├── reth-primitives-traits 1.0.1 │ │ │ ├── reth-trie-common 1.0.1 │ │ │ │ ├── reth-primitives 1.0.1 │ │ │ │ │ ├── sf-protos 0.1.0 │ │ │ │ │ └── decoder 0.1.1 │ │ │ │ └── decoder 0.1.1 │ │ │ └── reth-primitives 1.0.1 │ │ └── alloy-rpc-types 0.1.4 │ │ └── reth-primitives 1.0.1 │ └── alloy-rpc-types 0.1.0 │ ├── reth-rpc-types 0.2.0-beta.5 │ │ └── ethportal-api 0.2.2 │ ├── alloy-rpc-types-trace 0.1.0 │ │ └── reth-rpc-types 0.2.0-beta.5 │ └── alloy-rpc-types-engine 0.1.0 │ └── reth-rpc-types 0.2.0-beta.5 └── alloy-sol-macro 0.7.7

Crate: atty Version: 0.2.14 Warning: unsound Title: Potential unaligned read Date: 2021-07-04 ID: RUSTSEC-2021-0145 URL: rustsec.org/advisories/RUSTSEC-2021-0145

warning: 5 allowed warnings found

(Empty means OK! 👍)

gusinacio

LGTM

suchapalaver · 2024-10-16T19:20:43Z

Hey, could you take a look at the audit? There are a few crates that need some updates.

🤖 Cargo Audit Report 🤖
Crate: object_store Version: 0.9.1 Title: Apache Arrow Rust Object Store: AWS WebIdentityToken exposure in log files Date: 2024-07-23 ID: RUSTSEC-2024-0358 URL: rustsec.org/advisories/RUSTSEC-2024-0358 Severity: 3.8 (low) Solution: Upgrade to >=0.10.2 Dependency tree: object_store 0.9.1 └── flat-head 0.1.0
Crate: ansi_term Version: 0.12.1 Warning: unmaintained Title: ansi_term is Unmaintained Date: 2021-08-18 ID: RUSTSEC-2021-0139 URL: rustsec.org/advisories/RUSTSEC-2021-0139 Dependency tree: ansi_term 0.12.1 └── trin-utils 0.1.1-alpha.1 └── ethportal-api 0.2.2 ├── trin-validation 0.1.0 │ ├── header_accumulator 0.1.0 │ │ └── flat-head 0.1.0 │ └── flat-head 0.1.0 ├── sf-protos 0.1.0 │ ├── header_accumulator 0.1.0 │ ├── forrestrie 0.1.0 │ ├── flat-head 0.1.0 │ ├── firehose-client 0.1.0 │ │ └── forrestrie 0.1.0 │ └── decoder 0.1.1 │ ├── header_accumulator 0.1.0 │ └── flat-head 0.1.0 └── header_accumulator 0.1.0
Crate: atty Version: 0.2.14 Warning: unmaintained Title: atty is unmaintained Date: 2024-09-25 ID: RUSTSEC-2024-0375 URL: rustsec.org/advisories/RUSTSEC-2024-0375 Dependency tree: atty 0.2.14 └── trin-utils 0.1.1-alpha.1 └── ethportal-api 0.2.2 ├── trin-validation 0.1.0 │ ├── header_accumulator 0.1.0 │ │ └── flat-head 0.1.0 │ └── flat-head 0.1.0 ├── sf-protos 0.1.0 │ ├── header_accumulator 0.1.0 │ ├── forrestrie 0.1.0 │ ├── flat-head 0.1.0 │ ├── firehose-client 0.1.0 │ │ └── forrestrie 0.1.0 │ └── decoder 0.1.1 │ ├── header_accumulator 0.1.0 │ └── flat-head 0.1.0 └── header_accumulator 0.1.0
Crate: dotenv Version: 0.15.0 Warning: unmaintained Title: dotenv is Unmaintained Date: 2021-12-24 ID: RUSTSEC-2021-0141 URL: rustsec.org/advisories/RUSTSEC-2021-0141 Dependency tree: dotenv 0.15.0 └── flat-head 0.1.0
Crate: proc-macro-error Version: 1.0.4 Warning: unmaintained Title: proc-macro-error is unmaintained Date: 2024-09-01 ID: RUSTSEC-2024-0370 URL: rustsec.org/advisories/RUSTSEC-2024-0370 Dependency tree: proc-macro-error 1.0.4 ├── validator_derive 0.13.0 │ └── validator 0.13.0 │ └── ethportal-api 0.2.2 │ ├── trin-validation 0.1.0 │ │ ├── header_accumulator 0.1.0 │ │ │ └── flat-head 0.1.0 │ │ └── flat-head 0.1.0 │ ├── sf-protos 0.1.0 │ │ ├── header_accumulator 0.1.0 │ │ ├── forrestrie 0.1.0 │ │ ├── flat-head 0.1.0 │ │ ├── firehose-client 0.1.0 │ │ │ └── forrestrie 0.1.0 │ │ └── decoder 0.1.1 │ │ ├── header_accumulator 0.1.0 │ │ └── flat-head 0.1.0 │ └── header_accumulator 0.1.0 ├── alloy-sol-macro-expander 0.7.7 │ └── alloy-sol-macro 0.7.7 │ └── alloy-sol-types 0.7.7 │ ├── alloy-rpc-types-eth 0.1.4 │ │ ├── reth-primitives-traits 1.0.1 │ │ │ ├── reth-trie-common 1.0.1 │ │ │ │ ├── reth-primitives 1.0.1 │ │ │ │ │ ├── sf-protos 0.1.0 │ │ │ │ │ └── decoder 0.1.1 │ │ │ │ └── decoder 0.1.1 │ │ │ └── reth-primitives 1.0.1 │ │ └── alloy-rpc-types 0.1.4 │ │ └── reth-primitives 1.0.1 │ └── alloy-rpc-types 0.1.0 │ ├── reth-rpc-types 0.2.0-beta.5 │ │ └── ethportal-api 0.2.2 │ ├── alloy-rpc-types-trace 0.1.0 │ │ └── reth-rpc-types 0.2.0-beta.5 │ └── alloy-rpc-types-engine 0.1.0 │ └── reth-rpc-types 0.2.0-beta.5 └── alloy-sol-macro 0.7.7
Crate: atty Version: 0.2.14 Warning: unsound Title: Potential unaligned read Date: 2021-07-04 ID: RUSTSEC-2021-0145 URL: rustsec.org/advisories/RUSTSEC-2021-0145
warning: 5 allowed warnings found
(Empty means OK! 👍)

Let's create an issue for this, but getting CI to pass is the aim of this PR.

…oofs-for-historical-summary-given-historical-summaries-root test: compute proof for historical_record given historical_records_root

* build(header-accumulator): fix workspace crate dev-dependency import * build: install protoc in CI tests * fix(header-accumulator): fix cargo fmt * chore(flat-files-decoder): fix clippy::doc-lazy-continuation warning * chore(firehose-client): fix clippy::unnecessary_to_owned warning * chore(flat-files-decoder): fix clippy::filter_next warning * chore(sf-protos): fix code snippet in doc comment * chore(header-accumulator): fix clippy::bool_assert_comparison * chore(firehose-client): add streaming support for beacon and ethereum * build(forrestrie): add firehose-client as dependency * build(forrestrie): add reqwest as dependency * chore(forrestrie): make historical roots index public * chore(forrestrie): add fetch and verify block example * chore(forrestrie): add verify block inclusion proof example * chore(forrestrie): add historical state roots proof example * chore(forrestrie): add historical summary proof example * chore(forrestrie): add block roots proof example * chore(forrestrie): add block roots only proof example * chore(forrestrie): add empty slot hashes example * chore(firehose-client): add fetch ethereum block example * chore(firehose-client): add stream ethereum blocks example * chore(firehose-client): add stream beacon blocks example * chore(forehose-client): add fetch beacon block example * docs: add note on examples to README * build(workspace): use workspace dependency imports for legibility * ci(tests): remove coverage requirements for now

suchapalaver self-assigned this Oct 15, 2024

suchapalaver mentioned this pull request Oct 15, 2024

fix(header-accumulator): fix cargo fmt #2

Closed

suchapalaver force-pushed the joseph/back-34-veemon-fix-ci branch from 6258fa5 to 6e5c985 Compare October 15, 2024 20:32

build(header-accumulator): fix workspace crate dev-dependency import

a98c837

suchapalaver force-pushed the joseph/back-34-veemon-fix-ci branch 7 times, most recently from 81e75bb to 486f220 Compare October 16, 2024 00:11

suchapalaver added 5 commits October 15, 2024 21:35

build: install protoc in CI tests

f16bdfa

fix(header-accumulator): fix cargo fmt

93f2e00

chore(flat-files-decoder): fix clippy::doc-lazy-continuation warning

733a1f5

chore(firehose-client): fix clippy::unnecessary_to_owned warning

33c754e

chore(flat-files-decoder): fix clippy::filter_next warning

e40556a

suchapalaver force-pushed the joseph/back-34-veemon-fix-ci branch 3 times, most recently from b23deab to fa8ec11 Compare October 16, 2024 01:41

This comment has been minimized.

Sign in to view

chore(sf-protos): fix code snippet in doc comment

3705bb6

suchapalaver force-pushed the joseph/back-34-veemon-fix-ci branch from fa8ec11 to a65ce84 Compare October 16, 2024 01:52

This comment has been minimized.

Sign in to view

suchapalaver force-pushed the joseph/back-34-veemon-fix-ci branch from 32ea66e to e1ae752 Compare October 16, 2024 12:26

This comment has been minimized.

Sign in to view

suchapalaver force-pushed the joseph/back-34-veemon-fix-ci branch from e1ae752 to cdaf392 Compare October 16, 2024 13:20

suchapalaver added 12 commits October 16, 2024 13:36

chore(forrestrie): add verify block inclusion proof example

1e93ca9

chore(forrestrie): add historical state roots proof example

fa54cc1

chore(forrestrie): add historical summary proof example

087b3a0

chore(forrestrie): add block roots proof example

6ce6b94

chore(forrestrie): add block roots only proof example

3706e89

chore(forrestrie): add empty slot hashes example

f71482a

chore(firehose-client): add fetch ethereum block example

2330798

chore(firehose-client): add stream ethereum blocks example

74462fc

chore(firehose-client): add stream beacon blocks example

c79ee4f

chore(forehose-client): add fetch beacon block example

70a1664

docs: add note on examples to README

cd51b5b

build(workspace): use workspace dependency imports for legibility

b2b9f75

suchapalaver force-pushed the joseph/back-34-veemon-fix-ci branch from c7d67f2 to 0055aa7 Compare October 16, 2024 17:36

This comment has been minimized.

Sign in to view

suchapalaver marked this pull request as ready for review October 16, 2024 17:49

suchapalaver requested review from gusinacio, anirudh2, pedrohba1 and carlosvdr October 16, 2024 17:50

ci(tests): remove coverage requirements for now

5eff046

suchapalaver force-pushed the joseph/back-34-veemon-fix-ci branch from 0055aa7 to 5eff046 Compare October 16, 2024 18:38

gusinacio approved these changes Oct 16, 2024

View reviewed changes

suchapalaver merged commit 1e1a075 into main Oct 16, 2024
7 checks passed

suchapalaver deleted the joseph/back-34-veemon-fix-ci branch October 16, 2024 19:21

suchapalaver added a commit that referenced this pull request Nov 28, 2024

Merge pull request #3 from semiotic-ai/suchapalaver/test-inclusion-pr…

9eb2b78

…oofs-for-historical-summary-given-historical-summaries-root test: compute proof for historical_record given historical_records_root

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix ci: miscellaneous chores and fixes #3

fix ci: miscellaneous chores and fixes #3

suchapalaver commented Oct 15, 2024 •

edited

Loading

linear bot commented Oct 15, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 16, 2024

gusinacio commented Oct 16, 2024

gusinacio left a comment

suchapalaver commented Oct 16, 2024

fix ci: miscellaneous chores and fixes #3

fix ci: miscellaneous chores and fixes #3

Conversation

suchapalaver commented Oct 15, 2024 • edited Loading

BACK-36

linear bot commented Oct 15, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 16, 2024

gusinacio commented Oct 16, 2024

gusinacio left a comment

Choose a reason for hiding this comment

suchapalaver commented Oct 16, 2024

suchapalaver commented Oct 15, 2024 •

edited

Loading