Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: implement AccessTuple conversion methods in firehose-protos #29

Conversation

suchapalaver
Copy link
Contributor

No description provided.

@suchapalaver suchapalaver self-assigned this Oct 25, 2024
Copy link

linear bot commented Oct 25, 2024

@suchapalaver suchapalaver force-pushed the joseph/back-115-convert-receiptslogs-module-in-flat-files-decoder-with branch from 6bdcb09 to 5caf784 Compare October 25, 2024 15:03
@suchapalaver suchapalaver force-pushed the joseph/back-116-implement-accesstuple-conversion-methods-in-firehose-protos branch 2 times, most recently from 59e6704 to 58d500c Compare October 25, 2024 15:26
@suchapalaver suchapalaver force-pushed the joseph/back-115-convert-receiptslogs-module-in-flat-files-decoder-with branch 3 times, most recently from 6ce8897 to fd294d8 Compare October 25, 2024 19:45
Base automatically changed from joseph/back-115-convert-receiptslogs-module-in-flat-files-decoder-with to main October 25, 2024 19:46
@suchapalaver suchapalaver force-pushed the joseph/back-116-implement-accesstuple-conversion-methods-in-firehose-protos branch from 58d500c to 8c97ebe Compare October 25, 2024 19:49
@suchapalaver suchapalaver force-pushed the joseph/back-116-implement-accesstuple-conversion-methods-in-firehose-protos branch from 8c97ebe to 9033803 Compare October 25, 2024 19:53
@suchapalaver suchapalaver force-pushed the joseph/back-116-implement-accesstuple-conversion-methods-in-firehose-protos branch from 9033803 to 871676d Compare October 25, 2024 19:55
Copy link
Member

@anirudh2 anirudh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! As usual, this is much cleaner and easier to understand!

@suchapalaver suchapalaver marked this pull request as ready for review October 25, 2024 20:18
@suchapalaver suchapalaver merged commit 445858a into main Oct 25, 2024
6 checks passed
@suchapalaver suchapalaver deleted the joseph/back-116-implement-accesstuple-conversion-methods-in-firehose-protos branch October 25, 2024 20:18
suchapalaver added a commit that referenced this pull request Nov 28, 2024
…-method

refactor(firehose-client): add fetch_client method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants