Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure environment variables are passed correctly in integrations #2352

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ronzyfonzy
Copy link

  • Updated logic to properly handle and pass environment variables from integrations to tasks

This fix is connected to the discussion I opened up in General

- Updated logic to properly handle and pass environment variables from integrations to tasks
ronzyfonzy added a commit to ronzyfonzy/semaphore-docs that referenced this pull request Sep 20, 2024
…ments

Added clarification that an environment with matching keys is required for passing variables to tasks via integrations.

This is a response to some issues I had setting up an integration with Bitbucket. I also opened up a PR for the main project
semaphoreui/semaphore#2352
- Added logic to merge variables from both `ENV` and `JSON` fields
- Resolved issue where default environment variables were not being set
@fiftin
Copy link
Collaborator

fiftin commented Oct 1, 2024

t.Environment.JSON isn't environment variables. This JSON used in --extra-vars parameter of ansible-playbook.

@ronzyfonzy
Copy link
Author

Well then you must absolutely modify your docs where it states differently

https://github.com/semaphoreui/semaphore-docs/blob/fe6c8b493b5d7d47c9a0eceb8f738986372be6d1/user-guide/integrations.md?plain=1#L21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants