Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Accept undefined pluginConfig #16

Merged
merged 1 commit into from
Sep 18, 2017
Merged

fix: Accept undefined pluginConfig #16

merged 1 commit into from
Sep 18, 2017

Conversation

pvdlg
Copy link
Member

@pvdlg pvdlg commented Sep 18, 2017

Similar to semantic-release/commit-analyzer#12

Now that the plugin is the default one, a configuration in the release.generateNotes is not mandatory, therefore the plugin has to handle the case where pluginConfig is undefined.

@pvdlg pvdlg requested a review from gr2m September 18, 2017 03:12
@codecov
Copy link

codecov bot commented Sep 18, 2017

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #16   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          35     35           
=====================================
  Hits           35     35
Impacted Files Coverage Δ
lib/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91e575b...01a9657. Read the comment docs.

@gr2m
Copy link
Member

gr2m commented Sep 18, 2017

I wonder if this is something we should fix in semantic-release core, so that pluginConfig is always passed (defaulting to {})?

@pvdlg
Copy link
Member Author

pvdlg commented Sep 18, 2017

I wonder if this is something we should fix in semantic-release core, so that pluginConfig is always passed (defaulting to {})?

We could but that concerns only the default plugins.
For 3rd parties plugins I think there is always a pluginOption as it's where the custom plugin is defined in the release key of package.json

@gr2m gr2m merged commit 51b5e8d into master Sep 18, 2017
@gr2m gr2m deleted the undefined-options branch September 18, 2017 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants