Optimize insertFixture in database test trait

selective-php · Nov 27, 2022 · ab435aa · ab435aa
1 parent 0e6e183
commit ab435aa
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/src/Traits/DatabaseTestTrait.php b/src/Traits/DatabaseTestTrait.php
@@ -4,7 +4,6 @@
 
 use DomainException;
 use PDO;
-use PDOException;
 use PDOStatement;
 use UnexpectedValueException;
 
@@ -252,14 +251,9 @@ function (&$value) {
         $statement = $this->createPreparedStatement(sprintf('INSERT INTO `%s` SET %s', $table, implode(',', $fields)));
         $statement->execute($row);
 
-        try {
-            $lastInsertId = $this->getConnection()->lastInsertId();
+        $lastInsertId = $this->getConnection()->lastInsertId();
 
-            return !empty($lastInsertId) && is_numeric($lastInsertId) ? (int)$lastInsertId : null;
-        } catch (PDOException $PDOException) {
-            // If the PDO driver does not support this capability
-            return null;
-        }
+        return $lastInsertId !== false ? (int)$lastInsertId : null;
     }
 
     /**