Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sei Actions API's #194

Closed
wants to merge 12 commits into from
Closed

Sei Actions API's #194

wants to merge 12 commits into from

Conversation

codebycarson
Copy link
Collaborator

  • Adds a new @sei-js/create-sei command to spin up an express API application that has an EVM and cosmos action link.
  • Adds @sei-js/actions which defines the type interfaces for the action api standard on Sei

Copy link

changeset-bot bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: 76b91a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sei-js/actions Patch
@slinks/blink-ui Patch
@sei-js/create-sei Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (c0cd7a0) to head (19461d6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   84.47%   84.47%           
=======================================
  Files          16       16           
  Lines         161      161           
  Branches       25       25           
=======================================
  Hits          136      136           
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codebycarson codebycarson changed the title @sei-js/create-sei command for creating an actions compliant express API & @sei-js/actions for type interfaces for actions APIs Sei Actions API's Aug 22, 2024
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is kinda worthless, all this package does is export types, but our configuration requires at least one test to pass github actions, so I add this basic one.

export interface SeiActionConfig {
label: string;
href: string;
chainType: 'EVM' | 'COSMOS';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how I plan to distinguish between the two unless we hear otherwise from OKX on how they are doing it on EVM chains

Copy link
Contributor

@besated besated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! can u also update the readme in the actions package with the new info?

@@ -0,0 +1,25 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think we should include biome here, projects can add it themselves if they want it or other formatters

@codebycarson codebycarson deleted the feature/create-sei-action-link branch September 3, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants