Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor EVM package #187

Merged
merged 6 commits into from
Jul 9, 2024
Merged

Refactor EVM package #187

merged 6 commits into from
Jul 9, 2024

Conversation

besated
Copy link
Contributor

@besated besated commented Jul 4, 2024

  • Set up peer dependencies for ethers and viem
  • Split up exports for ethers and viem
  • Refactor precompile configs and helpers

Note: removed types for ethers for now, will create a separate PR using abitype for better typing

Copy link

changeset-bot bot commented Jul 4, 2024

🦋 Changeset detected

Latest commit: d707b9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sei-js/evm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (73c7494) to head (d707b9a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
- Coverage   84.56%   84.47%   -0.10%     
==========================================
  Files          17       16       -1     
  Lines         162      161       -1     
  Branches       25       25              
==========================================
- Hits          137      136       -1     
  Misses         25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@codebycarson codebycarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like these separated out!

@besated besated merged commit c2a0a4e into main Jul 9, 2024
2 checks passed
@besated besated deleted the besated/refactor-evm branch July 9, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants