fix: optional message parameter in JS clients (#47)

This makes `message` an optional parameter for auto-generated `track` calls, allowing you to make calls in `ts`-compiled files without passing in a message:

```
typewriter.fooBar()
```

instead of:

```
typewriter.fooBar({})
```

----

This also adds tests for ES5-transpiled clients (in this case, to validate that optional parameters were transpiled).

examples/gen-js/js/analytics/generated/index.d.ts

@@ -44,19 +44,19 @@ export default class Analytics {
   constructor(analytics: any);
 
   feedViewed(
-    message: FeedViewed,
+    message?: FeedViewed,
     options?: SegmentOptions,
     callback?: AnalyticsJSCallback
   ): void;
 
   photoViewed(
-    message: PhotoViewed,
+    message?: PhotoViewed,
     options?: SegmentOptions,
     callback?: AnalyticsJSCallback
   ): void;
 
   profileViewed(
-    message: ProfileViewed,
+    message?: ProfileViewed,
     options?: SegmentOptions,
     callback?: AnalyticsJSCallback
   ): void;

examples/gen-js/js/analytics/generated/index.js

@@ -18,7 +18,7 @@ export default class Analytics {
     }
     this.analytics = analytics || { track: () => null };
   }
-  feedViewed(props, context) {
+  feedViewed(props = {}, context) {
     var validate = function(
       data,
       dataPath,
@@ -101,7 +101,7 @@ export default class Analytics {
     }
     this.analytics.track("Feed Viewed", props, genOptions(context));
   }
-  photoViewed(props, context) {
+  photoViewed(props = {}, context) {
     var validate = function(
       data,
       dataPath,
@@ -184,7 +184,7 @@ export default class Analytics {
     }
     this.analytics.track("Photo Viewed", props, genOptions(context));
   }
-  profileViewed(props, context) {
+  profileViewed(props = {}, context) {
     var validate = function(
       data,
       dataPath,

examples/gen-js/node/analytics/generated/index.d.ts

@@ -168,7 +168,7 @@ export default class Analytics {
   constructor(analytics: any);
 
   orderCompleted(
-    message: TrackMessage<OrderCompleted>,
+    message?: TrackMessage<OrderCompleted>,
     callback?: AnalyticsNodeCallback
   ): void;
 }

examples/gen-js/node/analytics/generated/index.js

@@ -19,7 +19,7 @@ class Analytics {
     }
     this.analytics = analytics || { track: () => null };
   }
-  orderCompleted(message, callback) {
+  orderCompleted(message = {}, callback) {
     var validate = function(
       data,
       dataPath,

examples/gen-js/ts/analytics/generated/index.d.ts

@@ -44,19 +44,19 @@ export default class Analytics {
   constructor(analytics: any);
 
   feedViewed(
-    message: FeedViewed,
+    message?: FeedViewed,
     options?: SegmentOptions,
     callback?: AnalyticsJSCallback
   ): void;
 
   photoViewed(
-    message: PhotoViewed,
+    message?: PhotoViewed,
     options?: SegmentOptions,
     callback?: AnalyticsJSCallback
   ): void;
 
   profileViewed(
-    message: ProfileViewed,
+    message?: ProfileViewed,
     options?: SegmentOptions,
     callback?: AnalyticsJSCallback
   ): void;

examples/gen-js/ts/analytics/generated/index.js

@@ -18,7 +18,7 @@ export default class Analytics {
     }
     this.analytics = analytics || { track: () => null };
   }
-  feedViewed(props, context) {
+  feedViewed(props = {}, context) {
     var validate = function(
       data,
       dataPath,
@@ -101,7 +101,7 @@ export default class Analytics {
     }
     this.analytics.track("Feed Viewed", props, genOptions(context));
   }
-  photoViewed(props, context) {
+  photoViewed(props = {}, context) {
     var validate = function(
       data,
       dataPath,
@@ -184,7 +184,7 @@ export default class Analytics {
     }
     this.analytics.track("Photo Viewed", props, genOptions(context));
   }
-  profileViewed(props, context) {
+  profileViewed(props = {}, context) {
     var validate = function(
       data,
       dataPath,

src/commands/gen-js/library.ts

@@ -61,11 +61,11 @@ export function genJS(
       let trackCall = ''
       let validateCall = ''
       if (client === Client.js) {
-        parameters = 'props, context'
+        parameters = 'props = {}, context'
         trackCall = `this.analytics.track('${name}', props, genOptions(context))`
         validateCall = 'validate({ properties: props })'
       } else if (client === Client.node) {
-        parameters = 'message, callback'
+        parameters = 'message = {}, callback'
         trackCall = `
         message = {
           ...message,

src/commands/gen-js/typescript.ts

@@ -217,14 +217,14 @@ class AJSTSDeclarationsRenderer extends TypeScriptRenderer {
       if (this.ajsOptions.client === Client.js) {
         this.emitLine([
           camelCaseName,
-          '(message: ',
+          '(props?: ',
           this.sourceFor(t).source,
           ', options?: SegmentOptions, callback?: AnalyticsJSCallback): void'
         ])
       } else if (this.ajsOptions.client === Client.node) {
         this.emitLine([
           camelCaseName,
-          '(message: TrackMessage<',
+          '(message?: TrackMessage<',
           this.sourceFor(t).source,
           '>, callback?: AnalyticsNodeCallback): void'
         ])

tests/commands/gen-js/__snapshots__/index.amd.js

@@ -21,7 +21,7 @@ define(["require", "exports"], function(require, exports) {
       }
       this.analytics = analytics || { track: () => null };
     }
-    terribleEventName3(props, context) {
+    terribleEventName3(props = {}, context) {
       var validate = function(
         data,
         dataPath,
@@ -79,7 +79,7 @@ define(["require", "exports"], function(require, exports) {
         genOptions(context)
       );
     }
-    emptyEvent(props, context) {
+    emptyEvent(props = {}, context) {
       var validate = function(
         data,
         dataPath,
@@ -142,7 +142,7 @@ define(["require", "exports"], function(require, exports) {
       }
       this.analytics.track("Empty Event", props, genOptions(context));
     }
-    exampleEvent(props, context) {
+    exampleEvent(props = {}, context) {
       var pattern0 = new RegExp("FOO|BAR");
       var validate = function(
         data,
@@ -1020,7 +1020,7 @@ define(["require", "exports"], function(require, exports) {
       }
       this.analytics.track("Example Event", props, genOptions(context));
     }
-    draft04Event(props, context) {
+    draft04Event(props = {}, context) {
       var validate = function(
         data,
         dataPath,
@@ -1083,7 +1083,7 @@ define(["require", "exports"], function(require, exports) {
       }
       this.analytics.track("Draft-04 Event", props, genOptions(context));
     }
-    draft06Event(props, context) {
+    draft06Event(props = {}, context) {
       var validate = function(
         data,
         dataPath,

tests/commands/gen-js/__snapshots__/index.d.ts

@@ -167,7 +167,7 @@ export default class Analytics {
   constructor(analytics: any);
 
   the42TerribleEventName3(
-    message: The42_TerribleEventName3,
+    props?: The42_TerribleEventName3,
     options?: SegmentOptions,
     callback?: AnalyticsJSCallback
   ): void;
@@ -178,13 +178,13 @@ export default class Analytics {
    * Required object (empty) property
    */
   emptyEvent(
-    message: { [key: string]: any },
+    props?: { [key: string]: any },
     options?: SegmentOptions,
     callback?: AnalyticsJSCallback
   ): void;
 
   exampleEvent(
-    message: ExampleEvent,
+    props?: ExampleEvent,
     options?: SegmentOptions,
     callback?: AnalyticsJSCallback
   ): void;
@@ -195,7 +195,7 @@ export default class Analytics {
    * Required object (empty) property
    */
   draft04Event(
-    message: { [key: string]: any },
+    props?: { [key: string]: any },
     options?: SegmentOptions,
     callback?: AnalyticsJSCallback
   ): void;
@@ -206,7 +206,7 @@ export default class Analytics {
    * Required object (empty) property
    */
   draft06Event(
-    message: { [key: string]: any },
+    props?: { [key: string]: any },
     options?: SegmentOptions,
     callback?: AnalyticsJSCallback
   ): void;