Refactor the code #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjula-sack
force-pushed
the
main
branch
3 times, most recently
from
b5061db
to
c917f97
Compare
Piumal1999
requested changes
Aug 6, 2023
| const user: Profile | undefined = req.user as Profile | ||
|
|
||
| const { | ||
| primary_email, |
There was a problem hiding this comment.
If we are allowing the users to change the primary email, we have to do some additional validation to check whether that email is not associated with another profile
There was a problem hiding this comment.
primary_email is unique at the DB level. It will throw an error. But that error is not user friendly.
|
|
||
| res.status(200).json(updatedProfile.raw[0]) | ||
| } catch (err) { | ||
| console.error('Error executing query', err) |
There was a problem hiding this comment.
Can we keep some pre-defined set of common exceptions as we did in the previous version?
There was a problem hiding this comment.
yeah that's better, let's tackle it in a separate issue
Piumal1999
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix test running issues and refactor the code
Goals
Refactor the code
Approach
Refactored the code
Screenshots
Checklist