Add complete status #145
Merged
Add complete status #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the Mentee entity to use the UUID data type for the `certificate_id` column instead of the `bigint` data type. This change ensures compatibility with the UUID data type in the database and improves data integrity. Co-authored-by: Dileepa Mabulage <[email protected]>
The code changes in `utils.ts` update the path for generating certificates. The previous path `./src/certificates/mentee/${uniqueId}_certificate.pdf` has been changed to `./certificates/${uniqueId}_certificate.pdf`. This change ensures that the certificates are generated in the correct directory.
Note: Please remove any meta information like issue references, tags, or author names from the commit message.
anjula-sack
reviewed
Aug 1, 2024
src/utils.ts
Outdated
| './src/certificates/certificate_template.pdf', | ||
| `./src/certificates/mentee/${uniqueId}_certificate.pdf` | ||
| './certificates/certificate_template.pdf', | ||
| `./certificates/${uniqueId}_certificate.pdf` |
There was a problem hiding this comment.
what if the certificates directory doesn't exist?
The code changes update the path for generating certificates in `utils.ts`. The previous path `./src/certificates/mentee/${uniqueId}_certificate.pdf` has been changed to `./certificates/${uniqueId}_certificate.pdf`. This change ensures that the certificates are generated in the correct directory.
anjula-sack
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix #122
Goals
Approach
Screenshots
Checklist
Related PRs
#130
Test environment
Learning