-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests in Cirrus CI again #748
Open
stevesoltys
wants to merge
55
commits into
android15
Choose a base branch
from
feature/cirrus-ci-tests
base: android15
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesoltys
commented
Sep 19, 2024
build_script: | ||
- ./.github/scripts/build_aosp.sh aosp_arm64 ap1a userdebug android-14.0.0_r29 | ||
container: | ||
image: ghcr.io/cirruslabs/android-sdk:34 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to wait until they have an image for Android 15: https://github.com/cirruslabs/docker-images-android/pkgs/container/android-sdk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or just try setting it to android-35
below...
stevesoltys
force-pushed
the
feature/cirrus-ci-tests
branch
from
September 19, 2024 03:56
3391992
to
d755029
Compare
This also moves key derivation via HKDF into the core.
We still support downloading in v1 format for some time.
We still support restoring in v1 format for some time.
while maintaining support for v0 and v1
while maintaining support for v0 and v1
We'll probably keep metadata around for internal information about backup state
as it isn't needed anymore with v2 since we don't do duplicate restore sets anymore
The token used to be very important, because it was our restore set folder name. Now it is just a number in a snapshot, so things get a bit simpler.
This class is responsible for caching blobs during a backup run, so we can know that a blob for the given chunk ID already exists and does not need to be uploaded again. It builds up its cache from snapshots available on the backend and from the persistent cache that includes blobs that could not be added to a snapshot, because the backup was aborted.
which manages interactions with snapshots, such as loading, saving and removing them. It also keeps a reference to the latestSnapshot that holds important re-usable data.
Historically, metadata was uploaded to the backend after each app update and contained all essential data that is now in snapshots. We still support reading metadata for legacy backups and use the metadata classes as a common wrapper for snapshots. However, there is no need anymore to write out complete historic metadata and maintain duplicated unused information there. This got removed. THe information we do still save and write out is only for UI representation of backup state. The time of last backup is now managed by SettingsManager.
All snapshots we wrote out should be cached locally. Auto-restore is holding up app installs, so we should be as fast as possible.
stevesoltys
force-pushed
the
feature/cirrus-ci-tests
branch
2 times, most recently
from
September 25, 2024 02:38
2d51cb7
to
42185fb
Compare
We don't get notified about the start nor the end of such a backup run, so we need hacks to do initialization and finalization.
grote
force-pushed
the
feature/cirrus-ci-tests
branch
7 times, most recently
from
September 25, 2024 20:04
34226ab
to
8e46949
Compare
Instead of showing 'Waiting to be backed up...'
otherwise all LoggingFactory ClassLoader lookups that cause disk reads are logged when koin initializes classes
and those not annotated with @MediumTest
grote
force-pushed
the
feature/cirrus-ci-tests
branch
3 times, most recently
from
September 27, 2024 17:12
0dc1942
to
b9fc1a0
Compare
…lied Also add testkey for signed builds
grote
force-pushed
the
feature/cirrus-ci-tests
branch
from
September 27, 2024 17:39
b9fc1a0
to
7c2d869
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.