-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge and write periods #45
Conversation
When calling yearly_scalars_to_periodic_values it will rewrite values in elements. It will group for "name" column and then process to aggregate. Aggregation is happening as follows: 1: If the Entries are dicts (like input_parameter) it will take the first entry and leave it unchanged 2: Elif the Entries are lists or sequences it will check wheter they are sequences for the full period and write them to sequences, update foreign keys and write the foreign key. 3: Elif the entries are all equal the first entry will be written 4: Elif the entries are not equal they are written as a list
Also catching multiindex columns and Changing Typemapping to better type for Gas
I would have merged period scalars before parametrizing facades, aka one step before
This would preserve facade internal checks. Additionally, we would not have to create more facades than needed (for each period) and aggregate them later into single facades (which is also confusing IMO). Could you refactor code, so that period-aggregation is done before L372 and period scalars go into parametrization? I think as you already prepared the functions this is easy... |
Aggregation leads to empty fields that can be sequences. Fields that may be sequences are plumbed as `_Sequence` and afterwards saved in a wrong manner. When parametrizing the decorator should be updated to not plug values into plumbing and save them as they are.
Moving aggregation functionality to begining of When parametrizing the components and I have two ideas for solving the issue:
|
No, we decided to move the "to full length" extraction into
Not yet, but this shouldn't be a dependency for this. |
The deserialization of periodic values in oemof.tabular will be taken care of in PR#124 |
Fix naming bug adding comment
Closes #40
Check on periods and write them to the Data a method within Datapackage has been created. The Method
4.1. If the contents are dicts the first dicts is being used.
4.2. If the contents are lists or pandas sequences (
plumbin._Sequence
is not allowed) check if length the sum of found listsis equal to sequence length those sequences are added to timeseries data and foreign keys are written and updated
4.3 If all entries in the column are equal, only unique values is written
4.4 If the entries in columns are not all equal, a list with its values is written