-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding bus to parametrized elements iterative #35
Conversation
Adding busses by calling get_bus from Mapper. Also removed `cls` parameter from get_default and get bus since the class is stored in Mapper as `adapter` anyway.
PR looks good to me. Good catch that you removed
Could you explain it again? thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mini request.
Rest looks very good IMO
Sure :) If one |
Oh okay. You are right - and indeed this could be the very case! |
Working towards #31
Adding busses by calling get_bus from Mapper iterative. Please confirm that each
component
within anElement
should have the same busses.Slightly related change: removed
cls
parameter from get_default and get bus since the class is stored in Mapper asadapter
anyway.Ps.: Sorry for missing pre-commit run.