-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solved track loading issue (Soundcloud). #650
base: master
Are you sure you want to change the base?
Conversation
Can we have this committed so that Soundcloud works? Thanks! |
Works - thank you. ❤️ |
Been about a month and a half. Do we know when it is expected this will hit a release version? I'm not so great with Maven so I'm having issues applying this fix to another project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, although it looks like the fork's branch has been deleted
This seems like a small changes and fix the issue |
For all people waiting for a fix, there is a simple way to get this PR as dependency. no need to build it yourself or mess with jars: https://jitpack.io/#sedmelluq/lavaplayer/PR650-9af0c892ff-1 cc @HagarJNode @phamleduy04 @WearifulCupid0 @Asherlam because you asked in #653 Note that this will not include any new commits that might be added to this PR in the future. for that, replace |
@MCOfficer Thanks - It's working fine! |
Hello, |
^ right here, unless you actually want a jar. |
Yes, I want a jar. |
then go to the lavalink repo & grab the latest build from the ci wrong repo mate |
thanks |
OMG thank you, this worked! hash is "PR650-SNAPSHOT" |
Hi! Thanks for this fix but I cannot build it for today with error:
Is this caused from jitpack or something else? |
So, when will this be merged into master? |
Dev is MIA, you may use this fork instead: https://github.com/Walkyst/lavaplayer-fork |
To fix loading of tracks.