Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved track loading issue (Soundcloud). #650

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solved track loading issue (Soundcloud). #650

wants to merge 1 commit into from

Conversation

nayvcake
Copy link
Contributor

To fix loading of tracks.

@nayvcake nayvcake changed the title Solved track loading issue. Solved track loading issue (Soundcloud). Aug 14, 2021
@Sattishh
Copy link

Can we have this committed so that Soundcloud works?

Thanks!

@monty-dev
Copy link

Works - thank you. ❤️

@Djinnistorm
Copy link

Been about a month and a half. Do we know when it is expected this will hit a release version? I'm not so great with Maven so I'm having issues applying this fix to another project.

Copy link

@CyberFlameGO CyberFlameGO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although it looks like the fork's branch has been deleted

@mkcoldwolf
Copy link

This seems like a small changes and fix the issue
While this merge has been exist for like one and a half month
is the owner of this repo not active anymore?

Jjmarco added a commit to Jjmarco/lavaplayer that referenced this pull request Oct 2, 2021
Jjmarco added a commit to Jjmarco/lavaplayer that referenced this pull request Oct 2, 2021
@MCOfficer
Copy link
Contributor

MCOfficer commented Oct 4, 2021

For all people waiting for a fix, there is a simple way to get this PR as dependency. no need to build it yourself or mess with jars:

https://jitpack.io/#sedmelluq/lavaplayer/PR650-9af0c892ff-1

cc @HagarJNode @phamleduy04 @WearifulCupid0 @Asherlam because you asked in #653


Note that this will not include any new commits that might be added to this PR in the future. for that, replace 9af0c892ff with the new commit hash.

@HagarJNode
Copy link

@MCOfficer Thanks - It's working fine!

@MatthieuLeboeuf
Copy link

Hello,
Can I have the lavalink build with the soundcloud fix?
Sincerely

@MCOfficer
Copy link
Contributor

For all people waiting for a fix, there is a simple way to get this PR as dependency. no need to build it yourself or mess with jars:

jitpack.io/#sedmelluq/lavaplayer/PR650-9af0c892ff-1

cc @HagarJNode @phamleduy04 @WearifulCupid0 @Asherlam because you asked in #653

Note that this will not include any new commits that might be added to this PR in the future. for that, replace 9af0c892ff with the new commit hash.

^ right here, unless you actually want a jar.

@MatthieuLeboeuf
Copy link

Yes, I want a jar.

@topi314
Copy link

topi314 commented Oct 10, 2021

then go to the lavalink repo & grab the latest build from the ci

wrong repo mate

@MatthieuLeboeuf
Copy link

thanks

@dougvader
Copy link

OMG thank you, this worked! hash is "PR650-SNAPSHOT"

@Miha23833
Copy link

Hi! Thanks for this fix but I cannot build it for today with error:

       FAILURE: Build failed with an exception.
       
       * What went wrong:
       Could not determine the dependencies of task ':Main:shadowJar'.
       > Could not resolve all dependencies for configuration ':Main:runtimeClasspath'.
          > Could not find com.github.sedmelluq:lavaplayer:PR650-SNAPSHOT.
            Searched in the following locations:
              - https://repo.maven.apache.org/maven2/com/github/sedmelluq/lavaplayer/PR650-SNAPSHOT/maven-metadata.xml
              - https://repo.maven.apache.org/maven2/com/github/sedmelluq/lavaplayer/PR650-SNAPSHOT/lavaplayer-PR650-SNAPSHOT.pom
              - https://m2.dv8tion.net/releases/com/github/sedmelluq/lavaplayer/PR650-SNAPSHOT/maven-metadata.xml
              - https://m2.dv8tion.net/releases/com/github/sedmelluq/lavaplayer/PR650-SNAPSHOT/lavaplayer-PR650-SNAPSHOT.pom
              - https://jitpack.io/com/github/sedmelluq/lavaplayer/PR650-SNAPSHOT/maven-metadata.xml
              - https://jitpack.io/com/github/sedmelluq/lavaplayer/PR650-SNAPSHOT/lavaplayer-PR650-9af0c892ff-1.pom
            Required by:
                project :Main

Is this caused from jitpack or something else?

thedarkcolour added a commit to thedarkcolour/lavaplayer that referenced this pull request Mar 6, 2022
DxsSucuk added a commit to Ree6-Applications/lavaplayer that referenced this pull request Apr 25, 2022
@HagarJNode
Copy link

So, when will this be merged into master?

@MCOfficer
Copy link
Contributor

Dev is MIA, you may use this fork instead: https://github.com/Walkyst/lavaplayer-fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.