feat: add secp256k1 verify support #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libs/vm/src/vm-imports.ts
Outdated
| ); | ||
|
|
||
| try { | ||
| this.callResult = secp256k1Verify(message, signature, publicKey); |
There was a problem hiding this comment.
I believe true-myth is in this project. It would be better to do:
const result = trySync(() => secp...)
instead of doing try/catch
FranklinWaller
approved these changes
Sep 9, 2024
Thomasvdam
approved these changes
Sep 9, 2024
| import { beforeEach, describe, expect, it, mock } from "bun:test"; | ||
| import { readFile } from "node:fs/promises"; | ||
| import { executeDrWasm } from "@seda/dev-tools"; | ||
| import { Response } from "node-fetch"; |
There was a problem hiding this comment.
We're not using this import right?
mariocao
force-pushed
the
feat/secp256k1
branch
from
e1ad4a8
to
7922b4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
So that DR creators can verify data proxy signatures without having to implement the Secp256k1 verify logic.