Invalid json parsing errors #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update "json-as" to v0.9.26 There are still some values which should be invalid that get accepted, such as a string without the closing double quotes, but overall the error message for the edge cases we had have improved significantly. Stack traces are still poor due to the constraints of WASM, but there is work being done on a transform to allow try/catch and Rust style results.
Thomasvdam
force-pushed
the
feat/invalid-json-parsing
branch
from
12fbab8
to
3c99a53
Compare
FranklinWaller
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improved error messages when the received values don't match the declared types.
Explanation of Changes
Update "json-as" to v0.9.26
There are still some values which should be invalid that get accepted,
such as a string without the closing double quotes, but overall the
error message for the edge cases we had have improved significantly.
Stack traces are still poor due to the constraints of WASM, but there is
work being done on a transform to allow try/catch and Rust style
results.
Testing
Added a test that initially resulted in a max memory allocation error and now at least mentions that somewhere the user expected a string but received something else.
Related PRs and Issues
N.A.