Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete task015 (Elanor, Amar, Yi) #13

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Complete task015 (Elanor, Amar, Yi) #13

merged 2 commits into from
Sep 23, 2024

Conversation

amarshah1
Copy link
Contributor

See tasks/human_eval_015.rs. Let us know if there is anything else we should add.

parno
parno reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@parno parno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together. I added a few comments. After you address them, can you please run verusfmt?

tasks/human_eval_015.rs Outdated Show resolved Hide resolved
tasks/human_eval_015.rs Outdated Show resolved Hide resolved
tasks/human_eval_015.rs Outdated Show resolved Hide resolved
tasks/human_eval_015.rs Show resolved Hide resolved
tasks/human_eval_015.rs Outdated Show resolved Hide resolved
parno
parno approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@parno parno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- thanks!

@parno parno merged commit 65cdf99 into secure-foundations:main Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parno parno parno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amarshah1 @parno