Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember-cli to 3.28 #146

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 38 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
4f67bb7
fix some eslint errors
Gaurav0 Nov 15, 2021
b343bbd
remove ember-cli-updater
Gaurav0 Nov 15, 2021
01b6cbf
upgrade to ember 2.4
Gaurav0 Nov 15, 2021
010f1fd
fix lint
Gaurav0 Nov 15, 2021
9029828
fix commit error
Gaurav0 Nov 15, 2021
8947aa3
avoid deprecation warning
Gaurav0 Nov 16, 2021
9ec7b9d
remove ember-native-dom-helpers
Gaurav0 Nov 16, 2021
2e873df
ember-cli-update to 3.8
Gaurav0 Nov 16, 2021
8047bd4
ember-cli-update to 3.12
Gaurav0 Nov 16, 2021
a9d94a2
fix tests & lint
Gaurav0 Nov 16, 2021
166de88
Fix deprecations
Gaurav0 Nov 16, 2021
af889d1
ember-cli-update to 3.16
Gaurav0 Nov 18, 2021
fe1da76
fix lint
Gaurav0 Nov 18, 2021
65519c5
fix tests
Gaurav0 Nov 18, 2021
e6bbe19
ember-cli-update to 3.20
Gaurav0 Nov 19, 2021
82b0f65
fix lint
Gaurav0 Nov 19, 2021
37d2b0d
fix ember-try jquery scenario
Gaurav0 Nov 19, 2021
d829bf7
fix ember 3.8 ember-try scenario
Gaurav0 Nov 19, 2021
56b7cf2
ember-cli-update to 3.24
Gaurav0 Nov 19, 2021
f64c2ac
fix lint
Gaurav0 Nov 19, 2021
6571eea
ember-cli-update to 3.28
Gaurav0 Nov 19, 2021
cbb47f4
fix lint
Gaurav0 Nov 19, 2021
fc00343
drop compatibility with ember < 3.12
Gaurav0 Nov 22, 2021
a680133
update dependencies
Gaurav0 Nov 22, 2021
4c32e68
fix some deprecations
Gaurav0 Nov 22, 2021
4781151
replace ember-cli-github-pages with ef4/ember-cli-deploy-git
Gaurav0 Nov 22, 2021
96b5e7b
fix network issues
Gaurav0 Nov 22, 2021
93320c8
Update changelog
Gaurav0 Nov 22, 2021
0d3c9cb
address first partial review comments
Gaurav0 Nov 24, 2021
5fbd716
fix issue with included
Gaurav0 Nov 26, 2021
abd865c
run ember-cli-htmlbars codemod
Gaurav0 Nov 23, 2021
ea0ba33
try to fix legacy built ins deprecation
Gaurav0 Nov 24, 2021
cbef504
fix remaining deprecations
Gaurav0 Nov 26, 2021
671fd37
update github actions to test ember 4
Gaurav0 Nov 26, 2021
3ac5360
Drop support for Ember < 3.16
Gaurav0 Nov 26, 2021
7076267
update ember-auto-import to v2.x
Gaurav0 Nov 26, 2021
8d1f8e8
fix embroider optimized build
Gaurav0 Nov 26, 2021
01253c2
Update Changelog
Gaurav0 Nov 26, 2021
1288313
address feedback
Gaurav0 Dec 2, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,16 @@
"code",
"doc"
]
},
{
"login": "Gaurav0",
"name": "Gaurav Munjal",
"avatar_url": "https://avatars.githubusercontent.com/u/313960?v=4",
"profile": "http://gaurav0.github.io",
"contributions": [
"code"
]
}
]
],
"repoType": "github"
}
1 change: 0 additions & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

root = true


[*]
end_of_line = lf
charset = utf-8
Expand Down
22 changes: 22 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# unconventional js
/blueprints/*/files/
/vendor/

# compiled output
/dist/
/tmp/

# dependencies
/bower_components/
/node_modules/

# misc
/coverage/
!.*
.*/
.eslintcache

# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/package.json.ember-try
49 changes: 32 additions & 17 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,44 +1,59 @@
'use strict';

module.exports = {
root: true,
parser: 'babel-eslint',
parserOptions: {
ecmaVersion: 2017,
ecmaVersion: 2018,
sourceType: 'module',
ecmaFeatures: {
legacyDecorators: true,
},
},
plugins: ['ember'],
extends: ['eslint:recommended', 'plugin:ember/recommended'],
plugins: ['ember', 'prettier'],
extends: ['eslint:recommended', 'plugin:ember/recommended', 'plugin:prettier/recommended'],
env: {
browser: true,
},
rules: {
'ember/no-jquery': 'error',
'ember/avoid-leaking-state-in-ember-objects': [1, ['colorPalette']],
'ember/avoid-leaking-state-in-ember-objects': ['error', ['actions', 'colorPalette']],
'ember/no-get': 'off',
'ember/no-classic-components': 'off',
'ember/no-classic-classes': 'off',
'ember/require-tagless-components': 'off',
'ember/no-actions-hash': 'off',
'ember/no-component-lifecycle-hooks': 'off',
},
overrides: [
// node files
{
files: ['index.js', 'testem.js', 'ember-cli-build.js', 'config/**/*.js', 'tests/dummy/config/**/*.js'],
excludedFiles: ['app/**', 'addon/**'],
files: [
'./.eslintrc.js',
'./.prettierrc.js',
'./.template-lintrc.js',
'./ember-cli-build.js',
'./index.js',
'./testem.js',
'./blueprints/*/index.js',
'./config/**/*.js',
'./tests/dummy/config/**/*.js',
],
excludedFiles: ['addon/**', 'addon-test-support/**', 'app/**', 'tests/dummy/app/**'],
parserOptions: {
sourceType: 'script',
ecmaVersion: 2015,
},
env: {
browser: false,
node: true,
},
plugins: ['node'],
rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
// add your custom rules and overrides for node files here
}),
extends: ['plugin:node/recommended'],
},

// test files
{
files: ['tests/**/*.js'],
excludedFiles: ['tests/dummy/**/*.js'],
env: {
embertest: true,
},
// Test files:
files: ['tests/**/*-test.{js,ts}'],
extends: ['plugin:qunit/recommended'],
},
],
};
63 changes: 63 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
name: CI Build

on:
[ 'push', 'pull_request' ]

jobs:
test:
name: Tests
runs-on: ubuntu-latest
env:
JOBS: 1

steps:
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
- run: yarn install --frozen-lockfile --network-concurrency=1
- run: yarn lint
- run: yarn test:ember

floating-dependencies:
name: "Floating Dependencies"
runs-on: ubuntu-latest
env:
JOBS: 1

steps:
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
- run: yarn install --no-lockfile --network-concurrency=1
- run: yarn test:ember

try-scenarios:
name: "${{ matrix.ember-try-scenario }}"
runs-on: ubuntu-latest
env:
JOBS: 1

needs: test

strategy:
fail-fast: false
matrix:
ember-try-scenario:
- ember-default-with-jquery
- ember-classic
- ember-lts-3.24
- ember-lts-3.20
- ember-lts-3.16
- ember-release
- ember-beta
- ember-canary
- embroider-safe
- embroider-optimized

steps:
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
with:
node-version: 12.x
- name: install dependencies
run: yarn install --frozen-lockfile --network-concurrency=1
- name: test
run: node_modules/.bin/ember try:one ${{ matrix.ember-try-scenario }} --skip-cleanup
25 changes: 14 additions & 11 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,24 +3,27 @@
.vscode

# compiled output
/dist
/tmp
/dist/
/tmp/

# dependencies
/node_modules
/bower_components
/bower_components/
/node_modules/

# misc
/.env*
/.pnp*
/.sass-cache
/.idea
/.eslintcache
/connect.lock
/coverage/*
/coverage/
/libpeerconnection.log
npm-debug.log*
yarn-error.log
testem.log
/npm-debug.log*
/testem.log
/yarn-error.log

# ember-try
.node_modules.ember-try/
bower.json.ember-try
package.json.ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/package.json.ember-try
51 changes: 33 additions & 18 deletions .npmignore
Original file line number Diff line number Diff line change
@@ -1,21 +1,36 @@
/bower_components
# compiled output
/dist/
/tmp/

# dependencies
/bower_components/

# misc
/.bowerrc
/.editorconfig
/.ember-cli
/.env*
/.eslintcache
/.eslintignore
/.eslintrc.js
/.git/
/.gitignore
/.prettierignore
/.prettierrc.js
/.template-lintrc.js
/.travis.yml
/.watchmanconfig
/bower.json
/config/ember-try.js
/dist
/tests
/tmp
**/.gitkeep
.bowerrc
.editorconfig
.ember-cli
.eslintrc.js
.gitignore
.watchmanconfig
.travis.yml
bower.json
ember-cli-build.js
testem.js
/CONTRIBUTING.md
/ember-cli-build.js
/testem.js
/tests/
/yarn-error.log
/yarn.lock
.gitkeep

# ember-try
.node_modules.ember-try/
bower.json.ember-try
package.json.ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/package.json.ember-try
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v8.16.0
v12.22.1
21 changes: 21 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# unconventional js
/blueprints/*/files/
/vendor/

# compiled output
/dist/
/tmp/

# dependencies
/bower_components/
/node_modules/

# misc
/coverage/
!.*
.eslintcache

# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/package.json.ember-try
5 changes: 5 additions & 0 deletions .prettierrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
'use strict';

module.exports = {
singleQuote: true,
};
14 changes: 14 additions & 0 deletions .template-lintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
'use strict';

module.exports = {
extends: 'recommended',
rules: {
'no-invalid-interactive': false,
'no-inline-styles': false,
'self-closing-void-elements': false,
'no-curly-component-invocation': false,
'no-yield-only': false,
'no-action': false,
'no-duplicate-landmark-elements': false,
},
};
57 changes: 0 additions & 57 deletions .travis.yml

This file was deleted.

Loading