-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to ember-cli 3.28 #145
Closed
Changes from 29 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
4f67bb7
fix some eslint errors
Gaurav0 b343bbd
remove ember-cli-updater
Gaurav0 01b6cbf
upgrade to ember 2.4
Gaurav0 010f1fd
fix lint
Gaurav0 9029828
fix commit error
Gaurav0 8947aa3
avoid deprecation warning
Gaurav0 9ec7b9d
remove ember-native-dom-helpers
Gaurav0 2e873df
ember-cli-update to 3.8
Gaurav0 8047bd4
ember-cli-update to 3.12
Gaurav0 a9d94a2
fix tests & lint
Gaurav0 166de88
Fix deprecations
Gaurav0 af889d1
ember-cli-update to 3.16
Gaurav0 fe1da76
fix lint
Gaurav0 65519c5
fix tests
Gaurav0 e6bbe19
ember-cli-update to 3.20
Gaurav0 82b0f65
fix lint
Gaurav0 37d2b0d
fix ember-try jquery scenario
Gaurav0 d829bf7
fix ember 3.8 ember-try scenario
Gaurav0 56b7cf2
ember-cli-update to 3.24
Gaurav0 f64c2ac
fix lint
Gaurav0 6571eea
ember-cli-update to 3.28
Gaurav0 cbb47f4
fix lint
Gaurav0 fc00343
drop compatibility with ember < 3.12
Gaurav0 a680133
update dependencies
Gaurav0 4c32e68
fix some deprecations
Gaurav0 4781151
replace ember-cli-github-pages with ef4/ember-cli-deploy-git
Gaurav0 96b5e7b
fix network issues
Gaurav0 93320c8
Update changelog
Gaurav0 0d3c9cb
address first partial review comments
Gaurav0 5fbd716
fix issue with included
Gaurav0 abd865c
run ember-cli-htmlbars codemod
Gaurav0 ea0ba33
try to fix legacy built ins deprecation
Gaurav0 cbef504
fix remaining deprecations
Gaurav0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,6 @@ | |
|
||
root = true | ||
|
||
|
||
[*] | ||
end_of_line = lf | ||
charset = utf-8 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# unconventional js | ||
/blueprints/*/files/ | ||
/vendor/ | ||
|
||
# compiled output | ||
/dist/ | ||
/tmp/ | ||
|
||
# dependencies | ||
/bower_components/ | ||
/node_modules/ | ||
|
||
# misc | ||
/coverage/ | ||
!.* | ||
.*/ | ||
.eslintcache | ||
|
||
# ember-try | ||
/.node_modules.ember-try/ | ||
/bower.json.ember-try | ||
/package.json.ember-try |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,44 +1,59 @@ | ||
'use strict'; | ||
|
||
module.exports = { | ||
root: true, | ||
parser: 'babel-eslint', | ||
parserOptions: { | ||
ecmaVersion: 2017, | ||
ecmaVersion: 2018, | ||
sourceType: 'module', | ||
ecmaFeatures: { | ||
legacyDecorators: true, | ||
}, | ||
}, | ||
plugins: ['ember'], | ||
extends: ['eslint:recommended', 'plugin:ember/recommended'], | ||
plugins: ['ember', 'prettier'], | ||
extends: ['eslint:recommended', 'plugin:ember/recommended', 'plugin:prettier/recommended'], | ||
env: { | ||
browser: true, | ||
}, | ||
rules: { | ||
'ember/no-jquery': 'error', | ||
'ember/avoid-leaking-state-in-ember-objects': [1, ['colorPalette']], | ||
'ember/avoid-leaking-state-in-ember-objects': ['error', ['actions', 'colorPalette']], | ||
'ember/no-get': 'off', | ||
'ember/no-classic-components': 'off', | ||
'ember/no-classic-classes': 'off', | ||
'ember/require-tagless-components': 'off', | ||
'ember/no-actions-hash': 'off', | ||
'ember/no-component-lifecycle-hooks': 'off', | ||
}, | ||
overrides: [ | ||
// node files | ||
{ | ||
files: ['index.js', 'testem.js', 'ember-cli-build.js', 'config/**/*.js', 'tests/dummy/config/**/*.js'], | ||
excludedFiles: ['app/**', 'addon/**'], | ||
files: [ | ||
'./.eslintrc.js', | ||
'./.prettierrc.js', | ||
'./.template-lintrc.js', | ||
'./ember-cli-build.js', | ||
'./index.js', | ||
'./testem.js', | ||
'./blueprints/*/index.js', | ||
'./config/**/*.js', | ||
'./tests/dummy/config/**/*.js', | ||
], | ||
excludedFiles: ['addon/**', 'addon-test-support/**', 'app/**', 'tests/dummy/app/**'], | ||
parserOptions: { | ||
sourceType: 'script', | ||
ecmaVersion: 2015, | ||
}, | ||
env: { | ||
browser: false, | ||
node: true, | ||
}, | ||
plugins: ['node'], | ||
rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, { | ||
// add your custom rules and overrides for node files here | ||
}), | ||
extends: ['plugin:node/recommended'], | ||
}, | ||
|
||
// test files | ||
{ | ||
files: ['tests/**/*.js'], | ||
excludedFiles: ['tests/dummy/**/*.js'], | ||
env: { | ||
embertest: true, | ||
}, | ||
// Test files: | ||
files: ['tests/**/*-test.{js,ts}'], | ||
extends: ['plugin:qunit/recommended'], | ||
}, | ||
], | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
name: CI Build | ||
|
||
on: | ||
[ 'push', 'pull_request' ] | ||
|
||
jobs: | ||
test: | ||
name: Tests | ||
runs-on: ubuntu-latest | ||
env: | ||
JOBS: 1 | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: volta-cli/action@v1 | ||
- run: yarn install --frozen-lockfile --network-concurrency=1 | ||
- run: yarn lint | ||
- run: yarn test:ember | ||
|
||
floating-dependencies: | ||
name: "Floating Dependencies" | ||
runs-on: ubuntu-latest | ||
env: | ||
JOBS: 1 | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: volta-cli/action@v1 | ||
- run: yarn install --no-lockfile --network-concurrency=1 | ||
- run: yarn test:ember | ||
|
||
try-scenarios: | ||
name: "${{ matrix.ember-try-scenario }}" | ||
runs-on: ubuntu-latest | ||
env: | ||
JOBS: 1 | ||
|
||
needs: test | ||
|
||
strategy: | ||
fail-fast: false | ||
matrix: | ||
ember-try-scenario: | ||
- ember-default-with-jquery | ||
- ember-classic | ||
- ember-lts-3.24 | ||
- ember-lts-3.20 | ||
- ember-lts-3.16 | ||
# temporarily disabled until we've fixed support for Ember.js v4 | ||
# - ember-release | ||
# - ember-beta | ||
# - ember-canary | ||
# - embroider-safe | ||
# - embroider-optimized | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: volta-cli/action@v1 | ||
with: | ||
node-version: 12.x | ||
- name: install dependencies | ||
run: yarn install --frozen-lockfile --network-concurrency=1 | ||
- name: test | ||
run: node_modules/.bin/ember try:one ${{ matrix.ember-try-scenario }} --skip-cleanup |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,36 @@ | ||
/bower_components | ||
# compiled output | ||
/dist/ | ||
/tmp/ | ||
|
||
# dependencies | ||
/bower_components/ | ||
|
||
# misc | ||
/.bowerrc | ||
/.editorconfig | ||
/.ember-cli | ||
/.env* | ||
/.eslintcache | ||
/.eslintignore | ||
/.eslintrc.js | ||
/.git/ | ||
/.gitignore | ||
/.prettierignore | ||
/.prettierrc.js | ||
/.template-lintrc.js | ||
/.travis.yml | ||
/.watchmanconfig | ||
/bower.json | ||
/config/ember-try.js | ||
/dist | ||
/tests | ||
/tmp | ||
**/.gitkeep | ||
.bowerrc | ||
.editorconfig | ||
.ember-cli | ||
.eslintrc.js | ||
.gitignore | ||
.watchmanconfig | ||
.travis.yml | ||
bower.json | ||
ember-cli-build.js | ||
testem.js | ||
/CONTRIBUTING.md | ||
/ember-cli-build.js | ||
/testem.js | ||
/tests/ | ||
/yarn-error.log | ||
/yarn.lock | ||
.gitkeep | ||
|
||
# ember-try | ||
.node_modules.ember-try/ | ||
bower.json.ember-try | ||
package.json.ember-try | ||
/.node_modules.ember-try/ | ||
/bower.json.ember-try | ||
/package.json.ember-try |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
v8.16.0 | ||
v12.22.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# unconventional js | ||
/blueprints/*/files/ | ||
/vendor/ | ||
|
||
# compiled output | ||
/dist/ | ||
/tmp/ | ||
|
||
# dependencies | ||
/bower_components/ | ||
/node_modules/ | ||
|
||
# misc | ||
/coverage/ | ||
!.* | ||
.eslintcache | ||
|
||
# ember-try | ||
/.node_modules.ember-try/ | ||
/bower.json.ember-try | ||
/package.json.ember-try |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
'use strict'; | ||
|
||
module.exports = { | ||
singleQuote: true, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
'use strict'; | ||
|
||
module.exports = { | ||
extends: 'recommended', | ||
rules: { | ||
'no-invalid-interactive': false, | ||
'no-inline-styles': false, | ||
'self-closing-void-elements': false, | ||
'no-curly-component-invocation': false, | ||
'no-yield-only': false, | ||
'no-action': false, | ||
'no-duplicate-landmark-elements': false, | ||
}, | ||
}; |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it's a mistake to turn this one off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For accessibility, absolutely. For backward compatibility, however, no. We will have to fix accessibility when we are ready to break compatibility. Moving actions to dom nodes that are interactive will definitely break things.