Skip to content

Commit

Permalink
address feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
Gaurav0 committed Dec 2, 2021
1 parent 01253c2 commit 1288313
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 10 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
"configPath": "tests/dummy/config",
"demoURL": "https://secondstreet.github.io/ember-material-components-web/",
"versionCompatibility": {
"ember": ">=6.0"
"ember": ">=3.16.0"
}
},
"volta": {
Expand Down
28 changes: 19 additions & 9 deletions tests/dummy/config/targets.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,21 @@
'use strict';

const browsers = [
'last 2 Chrome versions',
'last 1 Firefox versions',
'last 1 Safari versions',
'last 1 Edge versions',
];
let browsers = ['last 1 Chrome versions', 'last 1 Firefox versions', 'last 1 Safari versions'];

const isCI = Boolean(process.env.CI);
const isProduction = process.env.EMBER_ENV === 'production';
const isOldScenario = process.env.EMBER_TRY_SCENARIO === 'ember-lts-3.16';

if (isCI || isProduction) {
browsers = [
'last 3 Chrome versions',
'last 3 iOS versions',
'last 2 ChromeAndroid versions',
'last 3 Firefox versions',
'last 2 Safari versions',
'last 3 Edge versions',
];
}

// Ember's browser support policy is changing, and IE11 support will end in
// v4.0 onwards.
Expand All @@ -18,9 +28,9 @@ const browsers = [
// const isCI = Boolean(process.env.CI);
// const isProduction = process.env.EMBER_ENV === 'production';
//
// if (isCI || isProduction) {
// browsers.push('ie 11');
// }
if (isProduction || isOldScenario) {
browsers.push('ie 11');
}

module.exports = {
browsers,
Expand Down

0 comments on commit 1288313

Please sign in to comment.