#2465 Setup the ev offset/min/max and add some sane default values. #2786
+21,238
−11,215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indra/newview/pipeline.cpp
Outdated
| exp_max = hdr_scale; | ||
| } | ||
| exp_min = dynamic_exposure_ev_offset - dynamic_exposure_ev_min; | ||
| exp_max = dynamic_exposure_ev_offset + dynamic_exposure_ev_max; |
There was a problem hiding this comment.
I learned the hard way that you need to actually call the cached controls for them to work reliably. Maybe it's only an issue for bool values? Or maybe there's something wrong with the LLCachedControl API...
There was a problem hiding this comment.
I'm curious to hear more about this. if the implicit casting operator const T&() for LLCachedControl is not functioning properly, we should figure out how to fix it
There was a problem hiding this comment.
To clarify, I would try to read the LLCachedControl bool for the first time before opening a floater to decide what UI to display, and it wouldn't work the first time.
Relevant PR:
Also restore notice messages about the selected viewer channel.
when picker was in a different mode
Modernize lltut.h. Allow both F32 and F64 for ensure_approximately_equals() etc. Use std::string_view instead of const char* for message string to allow passing std::string as well. Use stringize() instead of explicit std::stringstream idiom.
See "Example: Preventing a specific failing matrix job from failing a workflow run" https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-preventing-a-specific-failing-matrix-job-from-failing-a-workflow-run
Add GameControl behind feature-flag
…mapType (#2787) Co-authored-by: Maxim Nikolenko <[email protected]>
Fix GHA build config error
#2472: Debug tools for labeling textures
* #912 BugSplat Crash 1412267: nvoglv64+0xadcd00 * fix cherry-pick merge breakage. * Fix signed/unsigned error --------- Co-authored-by: Alexander Gavriliuk <[email protected]>
* Add missing names for controls to make content localizable * Fix labels for controls that are obviously wrong/make no sense
Fix issues with game control preferences
restore old JoystickAxis name convention
…rces for a user's profile.
… settings to prime some viewer-side plumbing and to better drive things with fewer conditional cases.
Tracy Improvements
#2991: Fix PBR terrain sometimes not loading textures
Fix url and toolbar menus binding callback functions to global scope
destroyRawImage is the only function that calls saveRawImage(), not calling it results in fetcher thinking that it still needs data to do the saving and looping back to trying to fetch.
Fix assert when retrieving data while mousing over minimap avatar dots
Update PBR terrain test plan
Server Issue #1493: New notification message for llTransferOwnership.
…cting the 1st tab (#3066)
Terrain was arriving and processing too late resulting in issues like "Lower terrain material incorrectly shown momentarily"
… sun light color.
Somehow this got crushed in a merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.