Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support non-semver SCM versions #48

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Conversation

bennettgoble
Copy link
Member

@bennettgoble bennettgoble commented Aug 10, 2024

Fall back to using the last git tag starting with v\d.+ if no valid semver is found. This is useful when using vendored tag versions such as openssl's v1.1.1q.

Fall back to using the last git tag starting with `v\d.+` if no valid semver is found.
This is useful when using vendored tag versions such as libcurl's `v1.1.1q`.
@bennettgoble bennettgoble added the bug Something isn't working label Aug 10, 2024
@bennettgoble bennettgoble merged commit 64e8430 into main Aug 10, 2024
11 checks passed
@bennettgoble bennettgoble deleted the signal/scm-wo-semver branch August 10, 2024 06:41
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2024
Copy link
Contributor

@brad-linden brad-linden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants