-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add standard github CI/CD #2
Conversation
.github/workflows/build.yaml
Outdated
build: | ||
strategy: | ||
matrix: | ||
os: [windows-2022, macos-12, ubuntu-22.04] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is macOS 12 correct here? Most of us are on macOS 13 or even 14 (mainly due to XCode requirements)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using macos-11 on most of the 3p projects. Looks like macos-13 is available, and macos-14 is in a public beta. I could switch to either of these, or we can swing around and update everything at once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
13 is required for CEF (mostly due to the Xcode requirement) and 14 was released September 26th although I haven't upgraded yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, then it probably makes sense to start moving any new builds to macos-13. I've bumped the version here. Thanks, Callum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is macOS runner version something that dependabot can surface in our consuming repos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, not yet anyways.
Wire up basic Github tooling.