Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard github CI/CD #2

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Add standard github CI/CD #2

merged 2 commits into from
Oct 6, 2023

Conversation

bennettgoble
Copy link
Member

Wire up basic Github tooling.

build:
strategy:
matrix:
os: [windows-2022, macos-12, ubuntu-22.04]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is macOS 12 correct here? Most of us are on macOS 13 or even 14 (mainly due to XCode requirements)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using macos-11 on most of the 3p projects. Looks like macos-13 is available, and macos-14 is in a public beta. I could switch to either of these, or we can swing around and update everything at once.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13 is required for CEF (mostly due to the Xcode requirement) and 14 was released September 26th although I haven't upgraded yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, then it probably makes sense to start moving any new builds to macos-13. I've bumped the version here. Thanks, Callum.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is macOS runner version something that dependabot can surface in our consuming repos?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, not yet anyways.

@bennettgoble bennettgoble merged commit bb864b3 into main Oct 6, 2023
4 checks passed
@bennettgoble bennettgoble deleted the signal/github branch October 6, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants